[asdf-devel] defsystem :version (:read-file-line ...) fails because :at key isn't recognized

[Faré]

1-  My apologies for the omission of read-file-line in uiop/stream. Oops.
Thanks for catching this.

2- reading a line doesn't involve the reader, only read-line, and so a
"safe" version is entirely superfluous, and an api for that seems bogus to
me.

3- Does the test suite run on Windows at all? I've never tried.

—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics•
http://fare.tunes.org
 The highest goal of computer science is to automate
that which can be automated. — Derek L. VerLee


On Thu, Aug 15, 2013 at 11:29 PM, Robert Goldman <rpgoldman at sift.info>wrote:

> Vsevolod Dyomkin wrote:
> > Hi,
> >
> > Basically, the problem is described in the message header.
> > Whereas :read-file-form option is used by ASDF itself, :read-file-line
> > isn't used and wasn't tested.
> >
> > Attached is a patch with relevant test cases and fixes.
> >
> > I would also suggest refactoring the code, because the code paths
> > for :read-file-form and :read-file-line are almost identical, but are
> > implemented in separate functions.
> >
> > Best regards,
> >
> > Vsevolod Dyomkin
> > +38-096-111-41-56
> > skype, twitter: vseloved
>
> I have incorporated this patch as written (no refactoring -- sorry, I
> have been too busy), and together with some documentation tweaks, have
> pushed it as 3.0.2.4.
>
> This is still a release candidate.  I won't make 3.0.3 until we have the
> directory pathname ticket fixes in and tested, and we have some test
> reports from others.  I haven't been testing on anything but Mac OS X
> Lion for a while now, and I don't know that /anyone/ has been testing on
> Windows.
>
> Best,
> Robert
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/asdf-devel/attachments/20130816/d474dd34/attachment.html>