<div dir="ltr"><div><div>1- My apologies for the omission of read-file-line in uiop/stream. Oops. Thanks for catching this.</div></div><div><br></div><div>2- reading a line doesn't involve the reader, only read-line, and so a "safe" version is entirely superfluous, and an api for that seems bogus to me.<div>
</div></div><div><br></div><div>3- Does the test suite run on Windows at all? I've never tried.</div><div><br></div><div class="gmail_extra"><div>—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• <a href="http://fare.tunes.org" target="_blank">http://fare.tunes.org</a><br>
</div>
<div class="gmail_extra">The highest goal of computer science is to automate</div><div class="gmail_extra">that which can be automated. — Derek L. VerLee</div><div><br></div><br><div class="gmail_quote">On Thu, Aug 15, 2013 at 11:29 PM, Robert Goldman <span dir="ltr"><<a href="mailto:rpgoldman@sift.info" target="_blank">rpgoldman@sift.info</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">Vsevolod Dyomkin wrote:<br>
> Hi,<br>
><br>
> Basically, the problem is described in the message header.<br>
> Whereas :read-file-form option is used by ASDF itself, :read-file-line<br>
> isn't used and wasn't tested.<br>
><br>
> Attached is a patch with relevant test cases and fixes.<br>
><br>
> I would also suggest refactoring the code, because the code paths<br>
> for :read-file-form and :read-file-line are almost identical, but are<br>
> implemented in separate functions.<br>
><br>
> Best regards,<br>
><br>
> Vsevolod Dyomkin<br>
> <a href="tel:%2B38-096-111-41-56" value="+380961114156">+38-096-111-41-56</a><br>
> skype, twitter: vseloved<br>
<br>
</div></div>I have incorporated this patch as written (no refactoring -- sorry, I<br>
have been too busy), and together with some documentation tweaks, have<br>
pushed it as 3.0.2.4.<br>
<br>
This is still a release candidate. I won't make 3.0.3 until we have the<br>
directory pathname ticket fixes in and tested, and we have some test<br>
reports from others. I haven't been testing on anything but Mac OS X<br>
Lion for a while now, and I don't know that /anyone/ has been testing on<br>
Windows.<br>
<br>
Best,<br>
Robert<br>
<br>
<br>
</blockquote></div><br></div></div>