[Ecls-list] mp.lsp with-lock diff review

Matthew Mondor mm_lists at pulsar-zone.net
Thu Oct 24 05:51:03 UTC 2013

Please review this diff, which basically makes two changes:

- Refer to the mp:*current-process* symbol once rather than twice to
  avoid redundant resolution
- Since the lock object's count slot is considered a fixnum by the
  internal code, also declare it as fixnum to avoid calling a
  comparison function

Since WITH-LOCK is a macro that's called rather often in MP code, this
provides some performance improvement with a few tests I've ran.

One thing also, is that I currently have various custom changes in my
tree which I wouldn't want to necessarily push to the official
repository (at least not immediately).  I began reading the progit book
so eventually I should know better what I'm doing with GIT, hopefully.
As such, feel free to commit the change if you have commit access and
like the diff.

It's also unclear to me if we should use this list for reviews in
general before commiting changes, but it's the policy of some projects
I've participated in; the opinion of others (especially the main
maintainer) on this would be good to have.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mp-diff.txt
URL: <https://mailman.common-lisp.net/pipermail/ecl-devel/attachments/20131024/342e75c6/attachment.txt>

More information about the ecl-devel mailing list