[Ecls-list] Patch: drop arg markers when propagating types

Josh Elsasser josh at elsasser.org
Mon Sep 1 22:13:43 UTC 2008


On Mon, Sep 01, 2008 at 09:04:45PM +0200, Juan Jose Garcia-Ripoll wrote:
> On Sat, Aug 30, 2008 at 10:54 PM, Josh Elsasser <josh at elsasser.org> wrote:
> > When retrieving a function's proclaimed argument types, the argument
> > markers such as &optional and &key are included, as well as any
> > following types.  The following patch stops processing at the first
> > marker.
> 
> Thanks a lot for pointing out this problem! However, instead of
> dropping these markers I have fixed the two functions that use these
> types: PROPAGATE-TYPES and GET-PROCLAIMED-NARG. In particular, the
> last function would not give the right results, neither before the fix
> nor if we dropped the markers. As an addition, using the marker types
> allows us to detect when a form passes too many or too few arguments
> to a proclaimed function.

Ah, thanks for coming up with a proper fix.  I'll admit that I was
more interested in getting the code to compile than figuring out how
ECL did type checking ;)




More information about the ecl-devel mailing list