[asdf-install-devel] Patches - unit test improvements, clarifying refactorings

[Dan Muller]

Merry Christmas -- another batch of patches added to my "submitted"
darcs repository. They can be pulled from here:

Naked darcs URL: http://danm.homelinux.org/darcs/asdf-install/submitted/
darcsweb URL: http://danm.homelinux.org/darcsweb.cgi

Patch descriptions follow. Note especially the unit test patch, which
is independent of the others. The only one which is likely to have an
effect on ASDF-INSTALL's behavior is the one named "More refactoring,
mostly in INSTALL-PACKAGES". The others are intended mainly to make
the code easier to understand.


Tue Dec 25 15:26:37 Eastern Standard Time 2007  Dan Muller<pikdj2002 at sneakemail.com>
  * Improved testing of unit test results.
  
  Added function ENSURE-INSTALL-RESULTS-SAME and used it in many of the
  tests. In particular, replaced the test for success in
  space-in-working-directory : test-1, allowing it to pass on Windows systems.
  
  One thing I don't quite understand: When I made this change, I
  discovered that installing moptilities also installs closer-mop in one
  unit test, but not in another unit test. This wasn't tested for
  before, so I don't know if it's expected or not. I adjusted the test
  success conditions so that they both pass despite this anomaly.
  

Tue Dec 25 14:46:24 Eastern Standard Time 2007  Dan Muller<pikdj2002 at sneakemail.com>
  * Canonicalized NEED-MORE-PACKAGES condition.
  
  This refactoring gathers together some of the more complicated
  defsystem-specific behavior by introducing an internal condition,
  NEED-MORE-PACKAGES. Instead of having to handle defsystem-specific
  conditions in core installation code, the code that tries to load a
  system is now responsible for translating defsystem-specific
  conditions to a NEED-MORE-PACKAGES condition, which is handled in a
  defsystem-independent fashion.
  
  This is only a small step towards better handling of multiple
  defsystems.
  

Tue Dec 25 13:12:55 Eastern Standard Time 2007  Dan Muller<pikdj2002 at sneakemail.com>
  * Gave local vars in INSTALL-PACKAGE more descriptive names.

Tue Dec 25 12:33:37 Eastern Standard Time 2007  Dan Muller<pikdj2002 at sneakemail.com>
  * More refactoring, mostly in INSTALL-PACKAGES.
  
  Changed the names of various variables in INSTALL-PACKAGES to clarify
  purpose and whether they involve packages or systems. (The distinction
  can usually be made clear, except when trying to recursively install
  missing components.) Also refactored the code to treat downloaded
  versus local archive files more similiarly; this required taking some
  additional care in what gets pushed on the local list SYSTEMS-TO-LOAD
  and the dynamic list *SYSTEMS-INSTALLED-THIS-TIME*.
  
  Also a minor simplification in CANONICAL-SYSTEM-NAME, addition of a
  doc string, clarification of a comment.
  

Tue Dec 25 11:20:10 Eastern Standard Time 2007  Dan Muller<pikdj2002 at sneakemail.com>
  * Factored out ONE-ITER as INSTALL-PACKAGES.
  
  First of several refactorings to make the code more legible. INSTALL
  was simply too large for me to easily comprehend.
  

Mon Dec 24 14:12:22 Eastern Standard Time 2007  Dan Muller<pikdj2002 at sneakemail.com>
  * Moved system name canonicalization to a separate function.

-- 
Dan Muller