Deferred warnings broken on SBCL 1.4.7

[Robert Goldman]

AFAICT, `UNREIFY-WARNINGS` only `APPLY`s the SBCL constructor to stashed 
property list.  So it's only the `REIFY` function that needs fixing.

I'm having a lot of difficulty figuring out exactly how to do the 
conditional compilation, though, because of ticklish issues about when, 
exactly code is being evaluated, read, etc.

On 30 May 2018, at 15:30, Faré wrote:

> Also, if you fix reify-warnings, you may have to fix unreify-warnings 
> with it.
> For a test, try to (uiop:enable-deferred-warnings-check) before you
> build software.
>
> —♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• 
> http://fare.tunes.org
> Passive hope is wishful thinking, a poison of the mind.
> Active hope is creative passion, the mover of the universe.
>
> On Wed, May 30, 2018 at 4:12 PM Robert Goldman <rpgoldman at sift.info> 
> wrote:
>>
>> Whoops.  Looks like this doesn't work on older SBCLs.  I'll fix that
>> now.
>>
>> R
>>
>>
>> On 30 May 2018, at 15:08, Robert Goldman wrote:
>>
>>> I have just pushed a merge request and topic branch for this.
>>>
>>> See https://gitlab.common-lisp.net/asdf/asdf/merge_requests/95
>>>
>>> I'm pretty scared about this -- we are getting in there and rooting
>>> around in SBCL internals in ways that seem almost guaranteed to 
>>> break
>>> again later.  But for now, I think it's fixed.
>>>
>>> Comments welcome -- especially comments involving a nicer rewrite of
>>> what I wrote.
>>>
>>> Best,
>>> R
>>>
>>> On 30 May 2018, at 12:13, Faré wrote:
>>>
>>>> On Wed, May 30, 2018 at 12:53 PM Eric Timmons <etimmons at mit.edu>
>>>> wrote:
>>>>> Somewhat related, I was curious why ASDF doesn't use Gitlab CI to
>>>>> automatically run tests. It probably wouldn't have helped in this
>>>>> particular case since the root cause was a change outside ASDF, 
>>>>> but
>>>>> it's still nice for things like merge requests.
>>>>
>>>> Well, there's about ten different scriptable implementations on 
>>>> three
>>>> major
>>>> platforms, plus multiple versions of each compiler and maybe extra
>>>> architectures to test for some of them. And then there are the
>>>> software
>>>> licensing issues for those operating systems and the proprietary
>>>> implementations. Finally, a complete test set would probably 
>>>> include
>>>> non-regression with cl-test-grid.
>>>>
>>>> Testing ASDF is a major undertaking. And even when all tests pass 
>>>> on
>>>> all
>>>> platforms, we have bad surprises, as demonstrated by the bumpy
>>>> releases 3.2
>>>> and 3.3.
>>>>
>>>> That said, even one image running tests on one implementation 
>>>> without
>>>> cl-test-grid would be an obvious improvement over the current
>>>> situation.
>>>>
>>>> Not being the maintainer anymore, nor paid to do it anymore, not
>>>> using it
>>>> for work or for fun anymore, I'd say "patches welcome".
>>>>
>>>> —♯ƒ • François-René ÐVB Rideau
>>>> •Reflection&Cybernethics•
>>>> http://fare.tunes.org
>>>> The state is the coldest of all cold monsters. Coldly it lies, too;
>>>> and this
>>>> lie creeps from its mouth: "I, the state, am the people."  —
>>>> Nietzsche
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/asdf-devel/attachments/20180530/5e0ee580/attachment.html>