<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8">
</head>
<body>
<div style="font-family:sans-serif"><div style="white-space:normal">
<p dir="auto">AFAICT, <code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0 0.4em" bgcolor="#F7F7F7">UNREIFY-WARNINGS</code> only <code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0 0.4em" bgcolor="#F7F7F7">APPLY</code>s the SBCL constructor to stashed property list. So it's only the <code style="background-color:#F7F7F7; border-radius:3px; margin:0; padding:0 0.4em" bgcolor="#F7F7F7">REIFY</code> function that needs fixing.</p>
<p dir="auto">I'm having a lot of difficulty figuring out exactly how to do the conditional compilation, though, because of ticklish issues about when, exactly code is being evaluated, read, etc.</p>
<p dir="auto">On 30 May 2018, at 15:30, Faré wrote:</p>
<blockquote style="border-left:2px solid #777; color:#777; margin:0 0 5px; padding-left:5px">
<p dir="auto">Also, if you fix reify-warnings, you may have to fix unreify-warnings with it.<br>
For a test, try to (uiop:enable-deferred-warnings-check) before you<br>
build software.</p>
<p dir="auto">—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• <a href="http://fare.tunes.org" style="color:#777">http://fare.tunes.org</a><br>
Passive hope is wishful thinking, a poison of the mind.<br>
Active hope is creative passion, the mover of the universe.</p>
<p dir="auto">On Wed, May 30, 2018 at 4:12 PM Robert Goldman <a href="mailto:rpgoldman@sift.info" style="color:#777">rpgoldman@sift.info</a> wrote:</p>
<blockquote style="border-left:2px solid #777; color:#999; margin:0 0 5px; padding-left:5px; border-left-color:#999">
<p dir="auto">Whoops. Looks like this doesn't work on older SBCLs. I'll fix that<br>
now.</p>
<p dir="auto">R</p>
<p dir="auto">On 30 May 2018, at 15:08, Robert Goldman wrote:</p>
<blockquote style="border-left:2px solid #777; color:#BBB; margin:0 0 5px; padding-left:5px; border-left-color:#BBB">
<p dir="auto">I have just pushed a merge request and topic branch for this.</p>
<p dir="auto">See <a href="https://gitlab.common-lisp.net/asdf/asdf/merge_requests/95" style="color:#BBB">https://gitlab.common-lisp.net/asdf/asdf/merge_requests/95</a></p>
<p dir="auto">I'm pretty scared about this -- we are getting in there and rooting<br>
around in SBCL internals in ways that seem almost guaranteed to break<br>
again later. But for now, I think it's fixed.</p>
<p dir="auto">Comments welcome -- especially comments involving a nicer rewrite of<br>
what I wrote.</p>
<p dir="auto">Best,<br>
R</p>
<p dir="auto">On 30 May 2018, at 12:13, Faré wrote:</p>
<blockquote style="border-left:2px solid #777; color:#BBB; margin:0 0 5px; padding-left:5px; border-left-color:#BBB">
<p dir="auto">On Wed, May 30, 2018 at 12:53 PM Eric Timmons <a href="mailto:etimmons@mit.edu" style="color:#BBB">etimmons@mit.edu</a><br>
wrote:</p>
<blockquote style="border-left:2px solid #777; color:#BBB; margin:0 0 5px; padding-left:5px; border-left-color:#BBB">
<p dir="auto">Somewhat related, I was curious why ASDF doesn't use Gitlab CI to<br>
automatically run tests. It probably wouldn't have helped in this<br>
particular case since the root cause was a change outside ASDF, but<br>
it's still nice for things like merge requests.</p>
</blockquote>
<p dir="auto">Well, there's about ten different scriptable implementations on three<br>
major<br>
platforms, plus multiple versions of each compiler and maybe extra<br>
architectures to test for some of them. And then there are the<br>
software<br>
licensing issues for those operating systems and the proprietary<br>
implementations. Finally, a complete test set would probably include<br>
non-regression with cl-test-grid.</p>
<p dir="auto">Testing ASDF is a major undertaking. And even when all tests pass on<br>
all<br>
platforms, we have bad surprises, as demonstrated by the bumpy<br>
releases 3.2<br>
and 3.3.</p>
<p dir="auto">That said, even one image running tests on one implementation without<br>
cl-test-grid would be an obvious improvement over the current<br>
situation.</p>
<p dir="auto">Not being the maintainer anymore, nor paid to do it anymore, not<br>
using it<br>
for work or for fun anymore, I'd say "patches welcome".</p>
<p dir="auto">—♯ƒ • François-René ÐVB Rideau<br>
•Reflection&Cybernethics•<br>
<a href="http://fare.tunes.org" style="color:#BBB">http://fare.tunes.org</a><br>
The state is the coldest of all cold monsters. Coldly it lies, too;<br>
and this<br>
lie creeps from its mouth: "I, the state, am the people." —<br>
Nietzsche</p>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</div>
</div>
</body>
</html>