[asdf-devel] Patch with ABCL specific changes
evenson at panix.com
Thu Nov 29 19:52:12 UTC 2012
On 11/29/12 3:29 PM, Faré wrote:
> On Wed, Nov 28, 2012 at 6:28 AM, Mark Evenson <evenson at panix.com> wrote:
>> Attached please find a patch synchronizing the version of ASDF we intend to
>> ship with abcl-1.1.0 with the canonical version.
>> These changes deal with bugs when using systems contained in jar archives
>> via the ABCL implementation specific extension of CL:PATHNAME.
> I've merged something based on it into asdf 2.26.3.
> Can you test it, and maybe ship it instead of your locally patched version,
> assuming I haven't release 2.27 yet?
The abcl build process is rather strict, exiting with failure if the
compilation emits warnings.
Could you possible push the attached patch to eliminate the warning, and
I'll grab the resulting code?
> Also, should your (find :windows *features*) actually be (os-windows-p) ?
> Note the subtle semantic different, where we consider it not windows
> if it's cygwin or other unix-on-windows environment.
> That may or may not apply to ABCL.
About the only way I can be convinced to use Windows is from Cygwin, so
#+abcl code in asdf.lisp has been tested as working under cygwin. As
far as I understand things, since the JVM is a Windows executable that
can be invoked outside of cygwin, even if abcl is invoked under cygwin
it will still manipulate file paths like a Windows process. When I get
a chance, I will study the usage of OS-WINDOWS-P to make sure that I am
not missing something here.
> BTW, when you locally patch, I recommend you use names such as 188.8.131.52;
> see explanations inside asdf.lisp.
"A screaming comes across the sky. It has happened before, but there is
nothing to compare it to now."
-------------- next part --------------
diff --git a/asdf.lisp b/asdf.lisp
@@ -2738,7 +2738,7 @@
(defun* oos (operation-class system &rest args
&key force force-not verbose version &allow-other-keys)
- (declare (ignore force verbose version))
+ (declare (ignore force force-not verbose version))
(apply 'operate operation-class system args))
More information about the asdf-devel