[armedbear-devel] [Patch] convert eql-specializer into a class (was Re: [Patch] add classes METAOBJECT, SPECIALIZER)

Mark Evenson evenson.not.org at gmail.com
Wed Jan 4 20:40:58 UTC 2012


On Jan 4, 2012, at 5:59 PM, Rudolf Schlatte wrote:

[…]

> Hi, thanks for applying!  Actually, I added some unused bits because of cargo-culting (Specializer.java, Metaobject.java).  The attached patch removes these files again, and converts eql-specializer into a class.  (intern-eql-specializer now contains a bit of the "quick and dirty means" that AMOP mentions in appendix C -- it's called while initalizing the generic function call machinery so we have to open-code the behavior of make-instance.)
> 
> <0001-Convert-EQL-SPECIALIZER-from-a-structure-into-a-CLOS.patch>

Good move, pushing the whole thing into CLOS.  The less Java the better.

I "corrected" the Java class naming to common conventions, as typically this marks code that we want to maintain.

Published as [svn r13715][1].

[1]: http://bit.ly/xEDz89



More information about the armedbear-devel mailing list