[armedbear-devel] Consolidating copy/paste code

Erik Huelsmann ehuels at gmail.com
Wed Apr 14 20:33:40 UTC 2010

Hi David,

On Mon, Apr 12, 2010 at 2:59 AM, David Kirkman <dkirkman at ucsd.edu> wrote:
> OK, Sounds like a nice afternoon project.  Here's a patch that does what I
> think you're asking in FaslReader and LispReader.

Exactly what I was talking about.

> But I ran into some trouble testing the changes.  Following the
> instructions at
>       http://common-lisp.net/project/armedbear/contributing.shtml
> I end up with an OutOfMemoryError when running both test.ansi.interpreted
> and test.ansi.compiled

That's probably where 30 minutes turned into an afternoon after all? :-)

I applied your patch, checked it for tabs (which I couldn't find:
perfect!), ran the tests and committed it as r12604. Thanks again for
your contribution!

Do you feel like contributing more, but you don't have any idea where
to start? You might want to have a look at ticket 88; it's a change to
provide ABCL with primitives for SLIME to use to find the right source
code. There's a comment in the ticket explaining my direction of
thoughts. If that's not enough, we can discuss on the list, here.

Although this is probably more like 2 or 3 afternoons since you're
very new in our code base.

Thanks again for your contribution!



More information about the armedbear-devel mailing list