slime-sexp-at-point in slime-repl buffers

[Stas Boukarev]

Marco Baringer <mb at bese.it> writes:

> Stas Boukarev <stassats at gmail.com> writes:
>
>> I object to the use of defadvice.
>
> why?
>
> - the slime-repl is a contrib and i don't want to modify the "builtin"
>   slime-sexp-at-point to support functionality which may or may not be
>   loaded.
>
> - this late modification of existing functions is exactly what defadvice
>   is supposed to do, the presence of advice is clearly shown by
>   describe-function and it can be disabled if needed.
>
> There are obviously (many) other ways to implement this (buffer local
> variables, custom flags, redefinition, etc.), but none of them seem as
> clear, to me at least, as a simple defadvice.
It's not apparent when reading the code that it may be redefined
somewhere else at some other time. Slime uses variables for cases like
this, see `slime-find-buffer-package-function', for example.

-- 
With best regards, Stas.