[slime-devel] Daily ChangeLog diff

[Helmut Eller]

* Mark Harig [2010-02-18 19:21+0100] writes:

> 1. 'n' and 'p' use the functions `next-line' and `previous-line',
> respectively.  Are these used intentionally in slime code
> instead of (forward-line 1) and (forward-line -1)?

Yes that's intentional.  The up/down cursor keys are usually bound to
next-line resp. previous-line.

forward-line only searches the next newline, while next-line goes to the
next line and additionally tries to preserve the current column among
other things.  forward-line is a primitive written in C and next-line
runs a ton of Lisp code.

> 2. If `previous-line' and `next-line' are not used intentionally,
> please find attached a patch that uses `forward-line'.  It also:
>
>   - replaces the obsolete (alias) variable `last-command-char' with
> `last-command-event'

Does that work in XEmacs?

>   - deletes the call to the obsolete function `make-local-hook'
> in the function `slime-add-local-hook', and simplifies the code.
>
> The patch is relative to slime.el, revision 1.1276
>
>
> +2010-02-17  Helmut Eller  <heller at common-lisp.net>
> +
> +   Select the xref buffer.
> +   I never could get used to the next/prev cycling.
> +
> +   * slime.el (slime-with-xref-buffer): Select the buffer.
> +   (slime-insert-xrefs): Add point-entered hook to automatically
> +   display the current location.
> +   (slime-xref-entered): New function.
>
> 3. There is no function named `slime-xref-entered' in slime.el,
> revision 1.1276.
> Was this unintentionally omitted?  Typing C-c C-c in the ChangeLog
> yields
> the error message: Source location of tag `slime-xref-entered' not found
> in file `slime.el'.  grep on *.el does not find this identifier, either.

It was there in 1.1274, but deleted in the next commit and I forgot to
mention it.   But you wouldn't find the deleted function anyway :-)

> Index: slime/contrib/ChangeLog
> diff -u slime/contrib/ChangeLog:1.343 slime/contrib/ChangeLog:1.345
> --- slime/contrib/ChangeLog:1.343   Mon Feb 15 16:42:37 2010
> +++ slime/contrib/ChangeLog Wed Feb 17 12:04:59 2010
> @@ -1,3 +1,10 @@
> +2010-02-17  Helmut Eller  <heller at common-lisp.net>
> +
> +   Fix bugs when *inferior-buffers* doesn't exist.
> +
> +   * inferior-slime.el (inferior-slime-start-transcript)
> +   (inferior-slime-stop-transcript): Make sure the buffer exists.
> +
>
> 4. This description was included in the contrib/Changelog twice.
> Was another description intended to be included instead?

No, I just botched the merge.

Thanks for the review :-) 
I committed some of your changes.

Helmut