[slime-devel] Daily ChangeLog diff

[Mark Harig]

+2010-02-17  Helmut Eller  <heller at common-lisp.net>
+
+   Point-entered hooks in the xref buffer don't work so well.
+   Use forward/backward commands instead.
+
+   * slime.el (slime-xref-next-line, slime-xref-prev-line): New
+   commands.
+   (slime-xref-show-location): New aux function.
+   (slime-xref-mode-map): Remap up/down to next/prev location
+   commands.  Make SPC and RET do the same.
+

1. 'n' and 'p' use the functions `next-line' and `previous-line',
respectively.  Are these used intentionally in slime code
instead of (forward-line 1) and (forward-line -1)?

>From the description of `next-line':

"If you are thinking of using this in a Lisp program, consider
using `forward-line' instead.  It is usually easier to use
and more reliable (no dependence on goal column, etc.)."

>From the description of `previous-line':

"If you are thinking of using this in a Lisp program, consider using
`forward-line' with a negative argument instead.  It is usually easier
to use and more reliable (no dependence on goal column, etc.)."

2. If `previous-line' and `next-line' are not used intentionally,
please find attached a patch that uses `forward-line'.  It also:

   - replaces the obsolete (alias) variable `last-command-char' with
`last-command-event'

   - deletes the call to the obsolete function `make-local-hook'
in the function `slime-add-local-hook', and simplifies the code.

The patch is relative to slime.el, revision 1.1276


+2010-02-17  Helmut Eller  <heller at common-lisp.net>
+
+   Select the xref buffer.
+   I never could get used to the next/prev cycling.
+
+   * slime.el (slime-with-xref-buffer): Select the buffer.
+   (slime-insert-xrefs): Add point-entered hook to automatically
+   display the current location.
+   (slime-xref-entered): New function.

3. There is no function named `slime-xref-entered' in slime.el, 
revision 1.1276.
Was this unintentionally omitted?  Typing C-c C-c in the ChangeLog 
yields
the error message: Source location of tag `slime-xref-entered' not found
in file `slime.el'.  grep on *.el does not find this identifier, either.


Index: slime/contrib/ChangeLog
diff -u slime/contrib/ChangeLog:1.343 slime/contrib/ChangeLog:1.345
--- slime/contrib/ChangeLog:1.343   Mon Feb 15 16:42:37 2010
+++ slime/contrib/ChangeLog Wed Feb 17 12:04:59 2010
@@ -1,3 +1,10 @@
+2010-02-17  Helmut Eller  <heller at common-lisp.net>
+
+   Fix bugs when *inferior-buffers* doesn't exist.
+
+   * inferior-slime.el (inferior-slime-start-transcript)
+   (inferior-slime-stop-transcript): Make sure the buffer exists.
+

4. This description was included in the contrib/Changelog twice.
Was another description intended to be included instead?

---
-------------- next part --------------
A non-text attachment was scrubbed...
Name: slime.el.1.1276.patch
Type: text/x-patch
Size: 2094 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/slime-devel/attachments/20100218/acbfb3ae/attachment.bin>