[slime-devel] Re: asdf:load'ing swank

[Christophe Rhodes]

Helmut Eller <heller at common-lisp.net> writes:

> * Christophe Rhodes [2007-09-12 16:47+0200] writes:
>
>> +  (swank-set :*swank-wire-protocol-version* (slime-version-string))
>>
>> Because I'm uncertain how much the base-level swank directory is open
>> to commits from dilettantes like me, I'm asking for review or some
>> kind of affirmation on this patch. 
>
> I think this kind of code is ugly.  It does what eval does, just much
> more verbose.  I would very much prefer a patch for swank.asd to make
> it load the source.

OK, I attach that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: swank-loader-script.diff
Type: text/x-diff
Size: 2458 bytes
Desc: swank.asd load as source
URL: <https://mailman.common-lisp.net/pipermail/slime-devel/attachments/20070912/9eaab429/attachment.diff>
-------------- next part --------------

>> (In the case where this patch or
>> something with equivalent functionality is completely vetoed, it would
>> probably be sensible to revoke my cvs permissions explicitly, or at
>> least explain the ground rules for using them).
>
> As a SBCL maintainer you can mess around with swank-sbcl.lisp as much
> as you like.  Modifications to the core should primarily be
> simplifications, i.e. the code should get shorter.  For contribs, do
> whatever you like.

Thanks.

Best,

Christophe