[slime-devel] Re: send-repl-results-to-emacs and slime-repl-insert-result.

[Vladimir Sedach]

Hmm, I don't think my patch should have affected REPL printing at all.
Do you mean to say that you are using my modification to listener-eval
in swank.lisp to replace the :write-string based
send-repl-results-to-emacs code?

As far as the interaction protocol goes, I agree that it does need to
be cleaned up. Obviously there are big problems with code rot if no
one noticed that the old REPL printing code was still there and
totally not being used.

Vladimir

PS - Madhu, I tried sending this reply directly to you, but your mail
server blacklists gmail.com. I think you may want to fix that.

On 6/14/07, Madhu <enometh at meer.net> wrote:
> * "Vladimir Sedach" <c07e645b0706061311l1f5beec3lcd3e734499f7dd2a at XXXX> :
>
> | In recent (or maybe not so recent) changes to swank.lisp,
> | send-repl-results-to-emacs sends a :write-string back to the slime
> | dispatcher instead of :return or :emacs-rex or whatever it was
> | previously. This means that slime-repl-eval-string never gets an :ok
> | result back, so the result printing code in slime-repl-insert-result
> | is of superfluous now (and can be deleted, but don't do that yet!).
>
> I have been using your patch. It does not get the repl results
> printing right as per the original code.
>
> In particular the issue I noted on
>  "Sun, 22 Apr 2007 22:46:07 +0530" <m3bqhgtj9w.fsf at robolove.meer.net>
>
> is still present. And I also get results like:
>
> CL-USER> (date)
> Fri Jun 15NIL
>  08:14:58 2007 +0530
>
> Is there a way I could use the advice mechanism to get the repl
> results printed correctly?
>
> I did not get a response from Mathias after he "fixed" the issue in
>  "Fri, 02 Feb 2007 09:58:38 +0530" <m3bqkgvoxi.fsf at robolove.meer.net>
>
> There is another issue with repl interaction:
>  "Fri, 27 Apr 2007 06:11:04 +0530" <m3tzv2vecf.fsf at robolove.meer.net>
>
> Would this suggest the repl interaction protocol design is lacking,
> and needs to be fixed at a more fundamental level?  (I don't use
> presentations myself, so my fix may not be applied to slime in
> general)
>
> --
> Regards
> Madhu
>
> _______________________________________________
> slime-devel site list
> slime-devel at common-lisp.net
> http://common-lisp.net/mailman/listinfo/slime-devel
>