[slime-devel] Re: [slime-cvs] CVS slime

Helmut Eller heller at common-lisp.net
Mon Nov 27 21:38:34 UTC 2006

* jsnellman [2006-11-26 19:08+0100] writes:

> Log Message:
> 	* swank-source-file-cache.lisp (buffer-first-change): Check
> 	whether a file exists before trying load it into the source
> 	cache.
>  (defimplementation buffer-first-change (filename)
>    "Load a file into the cache when the user modifies its buffer.
>  This is a win if the user then saves the file and tries to M-. into it."
> -  (unless (source-cached-p filename)
> -    (ignore-errors (source-cache-get filename (file-write-date filename)))))
> +  (unless (or (source-cached-p filename)
> +              (not (ignore-errors (probe-file filename))))
> +    (ignore-errors
> +      (source-cache-get filename (file-write-date filename)))))

I don't understand this change.  If the file doesn't exist then OPEN
will just fail (which is already handled).  And even if PROBE-FILE
succeeds, OPEN can still fail, e.g. because some other process deleted
the file in between.

Which problem does the patch solve?

More information about the slime-devel mailing list