[slime-devel] [PATCH] slime profiling - little fix

[Helmut Eller]

Pawel Ostrowski <pasza at zodiac.mimuw.edu.pl> writes:

> Hello,
> 
> When I was playing with slime profiling interface I encountered some
> errors:
> 
> - CMUCL 18e complained about (profiled-functions, profile-report,
>   profile-reset, unprofile-all, profile-package) symbols not being
>   exported by swank package when I tried entries from slime/profiling
>   menu. I just added missing exports to swank.lisp and it works fine,
>   however I do not know slime code well so it may be not the best
>   solution.

This is the right solution.  By convention, we export all symbols
called by Emacs from the SWANK package.  Recently we separated the
SWANK package from the SWANK-BACKEND, but the profile symbols were
only exported from the backend.  For many functions in the backend
functions we have a small wrapper in SWANK that does some argument
conversion, but these functions are so simple that we can just
re-export them.

> - (slime-unprofile-all) had no effect on CMUCL 18e because it called
>   (profile:unprofile) which is a macro. I replaced it with (eval
>   '(profile:unprofile)) and now it works fine.

This is a nice one.  The macro generates different code depending on
what functions are currently profiled.  Doh!  Thank you for the patches.

Helmut.