[mcclim-devel] ABORT gesture for ACCEPT (was: One char patch to presentation-defs [really future of McCLIM]

[rpgoldman at real-time.com]

    MGR> Hi

    MGR> On Mon, Aug 22, 2005 at 12:10:45PM -0500, Robert P. Goldman wrote:
    >> Similarly, as I mentioned earlier, it would be nice if one could use
    >> the ABORT gesture in the middle of ACCEPT and have something good
    >> happen.  Seems like if I type something bad and can't fix it in
    >> input-editing, I'm just doomed to complete the interaction, and then
    >> have the command fail into the debugger.  

[...snip...]

    MGR> Some minutes after you seemed to have left the channel I
    MGR> posted a patch for you. Basically it is just adding
    MGR> (handler-bind ((abort-gesture #'abort)) in the beginning of
    MGR> ACCEPT in presentation-defs.lisp. That seems to be okay.

    MGR> ABORT-GESTURE is the condition that is signaled when any of the
    MGR> gestures in *ABORT-GESTURES* is read (in STREAM-READ-GESTURE). Right
    MGR> now *ABORT-GESTURES* contains only :abort on mcclim, which is a the
    MGR> keyboard gesture (#\c :control) (on Genera it contains #\Abort, the
    MGR> ABORT-key).

    MGR> I do not find explicitly in the clim specification that an
    MGR> accept should be aborted on any abort-gesture, but it seems
    MGR> to be the right thing.

    MGR> I did short tests with ACCEPTING-VALUES and it seems to
    MGR> behave correctly with this patch, i.e. the whole dialog will
    MGR> be aborted. Or would it be better if only the editing of the
    MGR> single input-gadget is aborted?

    MGR> Also Genera CLIM and Dynamic Windows behave in the same way, although
    MGR> one gets thrown into the debugger if one presses ABORT during editing
    MGR> a text-field of an CLIM:ACCEPTING-VALUES dialog... This does not
    MGR> happen with McCLIM and this patch.

    MGR> If noone complains I'll apply it to the repository.

Has anyone squawked?  If not, how please do apply it.

Best,
R