[iterate-devel] fishy iterate use of delete...
Marc Battyani
marc.battyani at fractalconcept.com
Wed Nov 2 11:32:55 UTC 2005
"Faré" <fahree at gmail.com> wrote:
>while I was compiling cl-pdf, sbcl detected some invalid uses of
>delete in iterate.lisp. I checked that these errors were there in the
>iterate 1.4 release available from asdf-install.
>
>Indeed, (delete ...) has side-effects and doesn't preserve its second
>argument. Thus, a minimally disruptive patch would be to replace
>(delete entry
>index) with (setf index (delete entry index)) twice, and (delete
>nil temps) with (remove nil temps). Someone who understands the code
>better audit what is being done by the considered functions. Patch
>attached.
>
>Happily these errors didn't seem to affect the behaviour of cl-pdf.
I've fixed the iterate version in cl-pdf. (It will show up in the next
commit)
Marc
More information about the iterate-devel
mailing list