[Ecls-list] ECL failure with Pierre Mai's Deflate library

Pierre R. Mai pmai at pmsf.de
Fri Oct 8 15:46:21 UTC 2010


Am 08.10.2010 um 17:06 schrieb Zach Beane:

> When Abhishek Reddy told me that older versions of ECL don't fail with
> my test case, I tried a git-bisect and found that commit
> 5cfb33d7ad472e7a70d14069df4e374087c6117c, "Inline forms for
> ROW-MAJOR-AREF/ASET acting on specialized arrays with elements
> :[u]int{8,16,32,64}-t" fails on the test case, but the previous commit,
> 1c6132d28a464960d2d7a82bd534b7c712ed00d2, "Inline MAKE-ARRAY also when
> :INITIAL-ELEMENT is supplied.", does not fail. Both commits were made on
> May 25th of this year.

That seems indeed to be the source of the problem, since the entry for ext:integer64 references b16 instead of b64.  Changing this in my copy of ecl (see attached patch) and recompiling seems to fix the problem reported as issue 3082527.

The only remaining problem with Deflate is now the optimization bug in bit-stream-read-bits (the first issue reported).

> 
> Abhishek independently bisected and arrived at the same commit.
> 
> I tried to revert the failing commit changes on HEAD, but it didn't seem
> to help, and I'm not sure I was doing it right.
> 
> Zach

Regs, Pierre.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-typo-in-def-inline-definition-for-row-major-aref.patch
Type: application/octet-stream
Size: 973 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/ecl-devel/attachments/20101008/450cc533/attachment.obj>
-------------- next part --------------



-- 
Pierre R. Mai                                        <pmai at pmsf.de>
PMSF IT Consulting Pierre R. Mai                http://www.pmsf.de/
Blumenstr. 4                                          Goethestr. 32
85417 Marzling                                     87724 Ottobeuren
Tel. +49(0)8161/935 35 12                      +49(0)8332/936 69 13
Fax  +49(0)8161/935 35 08                      +49(0)8332/936 69 03
VAT ID / USt-ID Nr: DE 212838159                            Germany



More information about the ecl-devel mailing list