[drakma-devel] Re: [patch] drakma, support for connection-timeout on SBCL

[Erik Huelsmann]

On Dec 23, 2007 11:09 PM, Edi Weitz <edi at agharta.de> wrote:
> On Sun, 23 Dec 2007 06:13:43 +0100, Stanislaw Halik <sthalik at tehran.lain.pl> wrote:
>
> > As for the reason I haven't submitted the patch to usocket itself:
> > usocket is a compatibility layer, comprising of features readily
> > available in most of CL implementations. With socket timeouts
> > supported so far by only for LispWorks and SBCL, I believe the patch
> > would have no chances of getting accepted.
>
> Let's do it like this:
>
> 1. Ask them.  That doesn't cost anything.  They can still offer to
>    support timeouts and make that a no-op for implementations which
>    don't have them (like Drakam does).  (Also, are you sure it's only
>    LispWorks and SBCL?  Have you checked AllegroCL for example?)
>
> 2. If they say yes, that's fine and I'll update Drakma to work with
>    the latest usocket release.

Well, I think they'll accept (a patch which fits into the usocket
framework), especially since timeouts come for free in Allegro and
CLISP (through a with-timeout macro and a :timeout parameter
respectively). Research should be able to turn up ways to achieve the
same thing in other lisps.

In a portability library you generally can't be expected to implement
a feature for all supported platforms. However: the more you submit
with the original patch, the bigger the chances for integration.

bye,


Erik.