[cl-typesetting-devel] leading/line-spacing and text style

[Marc Battyani]

Dmitriy Ivanov wrote:
> Hello Cyrus,
>
> | The following patch adds leading-ratio to the style.
>
> Thanks Cyrus. Slightly modified, works for me.
> I have just committed specials.lisp and typo.lisp to the repository.
> Please update and test.
>
> I also suggest avoiding the heavy decoration feature via the
> :no-typeset-decoration feature. For example:
>
> (defclass text-style (style)
>   ((font :accessor font :initform nil)
>    (font-size :accessor font-size :initarg :font-size :initform nil)
>    (text-x-scale :accessor text-x-scale :initarg :text-x-scale :initform
> nil)
>    (color :accessor color :initarg :color :initform nil)
>    (background-color :accessor background-color :initarg :background-color
> :initform nil)
>    (h-align :accessor h-align :initarg :h-align :initform nil)
>    (left-margin :accessor left-margin :initarg :left-margin :initform nil)
>    (right-margin :accessor right-margin :initarg :right-margin :initform
> nil)
>    #-no-typeset-decoration (pre-decoration :accessor pre-decoration :initarg
> :pre-decoration :initform nil)
>    #-no-typeset-decoration (post-decoration :accessor post-decoration
> :initarg :post-decoration :initform nil)
>    (leading-ratio :accessor leading-ratio :initarg :leading-ratio :initform
> nil)))
>
> and so on.
>
> What do other folks think?
>   
It's ok for me. but maybe it's better to have some run time switch to decide on a per typesetting engine if decorations are needed or not. Otherwise if an application has at least one document which uses it, the other documents will be impacted.

Marc