[cl-store-devel] ABCL tests

[szergling]

Hi all,

I'm trying to get cl-store to run on ABCL, and it required the
following patches.

These are for

CL-STORE> (lisp-implementation-version)
"0.0.9"


--- /cygdrive/c/home/code/lisp/cl-store_0.7/utils.lisp	2006-08-05
02:40:02.000000000 +1200
+++ /cygdrive/c/home/temp/utils.lisp	2007-11-13 18:53:12.432977500 +1300
@@ -51,8 +51,8 @@
   (:documentation
    "Return a list of slot details which can be used
     as an argument to ensure-class")
-  (:method ((slot-definition #+(or ecl (and clisp (not mop))) t
-                             #-(or ecl (and clisp (not mop))) slot-definition))
+  (:method ((slot-definition #+(or ecl abcl (and clisp (not mop))) t
+                             #-(or ecl abcl (and clisp (not mop)))
slot-definition))
    (list :name (slot-definition-name slot-definition)
          :allocation (slot-definition-allocation slot-definition)
          :initargs (slot-definition-initargs slot-definition)



Note that in ABCL, we have a good example of

CL-STORE> (eq 4 4)
NIL

so although most of cl-store has been careful about this, were there
any more slips?


--- /cygdrive/c/home/code/lisp/cl-store_0.7/circularities.lisp	2006-08-05
02:40:02.000000000 +1200
+++ /cygdrive/c/home/temp/circularities.lisp	2007-11-13 18:53:30.684495900 +1300
@@ -105,7 +105,7 @@
   (declare (optimize speed (safety 1) (debug 0)))
   (let ((*stored-counter* 0)
         (*stored-values* (and *check-for-circs*
-                              (make-hash-table :test #'eq :size
*store-hash-size*))))
+                              (make-hash-table :test #'eql :size
*store-hash-size*))))
     (store-backend-code backend place)
     (backend-store-object backend obj place)
     obj))
@@ -167,7 +167,7 @@
   (let ((*restore-counter* 0)
         (*need-to-fix* nil)
         (*restored-values* (and *check-for-circs*
-                                (make-hash-table :test #'eq
+                                (make-hash-table :test #'eql
                                                  :size *restore-hash-size*))))
     (check-magic-number backend place)
     (prog1

Perhaps the test should be even more general? #'equal?

At the moment, there were quite a few failed tests, and I cannot even
finish large.1
so these two patches are by no means complete. I probably won't have the time
to play on this, so it's semi-workable for now.

This is a regexp search of the test log. Presumably all the other ones passed.


      3:Test CL-STORE-TESTS::PACKAGE.1 failed
      7:Test CL-STORE-TESTS::PACKAGE.2 failed
     11:Test CL-STORE-TESTS::STANDARD-OBJECT.1 failed
     15:Test CL-STORE-TESTS::STANDARD-OBJECT.2 failed
     19:Test CL-STORE-TESTS::STANDARD-OBJECT.3 failed
     23:Test CL-STORE-TESTS::STANDARD-OBJECT.4 failed
     27:Test CL-STORE-TESTS::STANDARD-CLASS.1 failed
     31:Test CL-STORE-TESTS::STANDARD-CLASS.2 failed
     35:Test CL-STORE-TESTS::STANDARD-CLASS.3 failed
     39:Test CL-STORE-TESTS::CONDITION.1 failed
     43:Test CL-STORE-TESTS::CONDITION.2 failed
     48:Test CL-STORE-TESTS::CIRC.5 failed
     53:Test CL-STORE-TESTS::CIRC.13 failed

large.1 caused evaluation to be aborted.