[cl-muproc-devel] [Patch] openmcl support

[Rudi Schlatte]

On 6. Jul 2006, at 08:53, Klaus Harbo wrote:

> I just installed your patch.  It looks very good indeed:   
> Everything seems to works as intended -- the tests all pass and the  
> system we're building also seems to be doing just fine.  Excellent!

Good to hear that, thanks!

> I have reviewed all your changes, and have only a single comment:   
> You introduce *muproc-spawn-lock* to serialize access to muproc- 
> spawn.  I think perhaps it would be preferable to simply use %with- 
> exclusive-access%.  In fact, thinking about this it occurred to me  
> that (the previously existing) *giant-lock* probably be ought to be  
> placed in the implementation specific files (muproc- 
> {lispworks,openmcl}.lisp) because, strictly speaking, it is an  
> artifact of the implementation of %with-exclusive-access% and not  
> part of the implementation independent part of muproc.

I agree re *giant-lock*.  If I recall correctly, I introduced a  
second lock so as not to have to think about nested %with-exclusive- 
access% forms.  In that case, the locks must be recursive or %with- 
exclusive-access% must be a bit smarter.  I coded the simplest thing  
and then never revisited the decision.

> So I propose that the new serialized muproc-spawn uses the generic % 
> with-exclusive-access%, that *giant-lock* is moved to both  
> implementation-specific files, and that *muproc-spawn-lock* is  
> eliminated.

Sounds good.  I also forgot to remove %without-scheduling% from the  
muproc-compat package; that symbol is not used any more, so can be  
eliminated.

Cheers,

Rudi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <https://mailman.common-lisp.net/pipermail/cl-muproc-devel/attachments/20060707/902fb4c6/attachment.sig>