[Bese-devel] [yaclml] [patch] fixed inconsistency between NODE-CHILDREN and MAKE-NODE, (SETF NODE-CHILDREN) in XMLS

Boris Smilga boris.smilga at gmail.com
Fri Mar 11 21:29:00 UTC 2011


Hi.

This is a minor issue, actually.  In yaclml/src/tal/xmls.lisp, we read:

  (defun make-node (&key name ns attrs child children)
    (cons #<Datum for name, ns and attrs> #<Datum for child or children>))

and, correspondingly,

  (defun (setf node-children) (children elem)
    (setf (CDR elem) children)
    (node-children elem))

but, at the same time,

  (defun node-children (elem)
    (CDDR elem))

which results in the first child being lost.

Attached is a patch to fix this issue.

Sincerely,
 - B. Smilga.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/bese-devel/attachments/20110312/3d2fb421/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: node-children.dpatch
Type: application/octet-stream
Size: 3777 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/bese-devel/attachments/20110312/3d2fb421/attachment.obj>


More information about the bese-devel mailing list