[asdf-install-devel] Patches - unit test improvements, clarifying refactorings

[Dan Muller]

"Dan Muller pikdj2002-at-sneakemail.com |Open Source Author/Both|" <...> writes:

> Gary King wrote:
>> I've also altered the patch that mostly involved tab/space
>> consistency. In the deftestsuite test-asdf-install (below), you had
>> removed the (:setup ...) clause. I've put it back but will remove it
>> if there is a reason for it being removed.
[conflict code elided]
>
> OK, I'm home now and have just taken time to look into this. I know
> what happened, and it's not pretty. My working repository is based on
> stable; that's all that was available when I started this work. But
> unstable, which you made available later, has a bunch of additional
> patches in it! And I didn't notice that until about three minutes
> ago...
>
> I hope that doesn't make my other patches too hard to apply! I'm going
> to try merging unstable into (a copy of) my working repository.
>

I've updated my "submitted" repository to include all of unstable,
plus a conflict resolution patch for test-asdf-install.lisp.

This made my unit tests on Linux work a bit better; but I've got new
failures on Windows that I have to investigate. I figured it was
worthwhile to get make the conflict resolution patch available in the
meantime, though.

BTW, one of the things that was vexing me on Linux is that SBCL seems
to have ASDF-INSTALL preloaded, or something. Whenever ASDF was asked
to load it or compile it, it was going to the old, system-wide
installation. I worked around this by explicitly loading the test
version's .asd file, and that got me a bit further along.

-- 
Dan Muller