[asdf-install-devel] Patches - unit test improvements, clarifying refactorings

[Dan Muller]

Gary King wrote:
> I've also altered the patch that mostly involved tab/space
> consistency. In the deftestsuite test-asdf-install (below), you had
> removed the (:setup ...) clause. I've put it back but will remove it
> if there is a reason for it being removed.
>
>> (deftestsuite test-asdf-install ()
>>   ()
>>   (:dynamic-variables
>>    (*locations*
>>     `((,(merge-pathnames (make-pathname :directory '(:relative
>> "site"))
>> 			 *working-directory*)
>> 	,(merge-pathnames (make-pathname :directory '(:relative "site- 
>> systems"))
>> 			  *working-directory*)
>> 	"temporary install")))
>>    (*preferred-location* "temporary install")
>>    (asdf-install::*private-asdf-install-dirs* "")
>>    (asdf:*central-registry*
>>     (list
>>      (merge-pathnames (make-pathname :directory '(:relative "site- 
>> systems"))
>> 		      *working-directory*))))
>>   (:setup
>>    (delete-directory-and-files *working-directory* :verbose? t
>> 			       :if-does-not-exist :ignore)
>>    (ensure-directories-exist *working-directory*)))
>

OK, I'm home now and have just taken time to look into this. I know
what happened, and it's not pretty. My working repository is based on
stable; that's all that was available when I started this work. But
unstable, which you made available later, has a bunch of additional
patches in it! And I didn't notice that until about three minutes
ago...

I hope that doesn't make my other patches too hard to apply! I'm going
to try merging unstable into (a copy of) my working repository.

-- 
Dan Muller