read-depend branch is ready for another review...

[Faré]

>> 1. what's in FIND-SYSTEM is accessors to %ADDITIONAL-INPUT-FILES, not
>> ADDITIONAL-INPUT-FILES and the former has setters as well as getters, so
>> I wasn't sure I could use ADDITIONAL-INPUT-FILES.  I'll check.
>
> Checked and confirmed this -- %ADDITIONAL-INPUT-FILES takes only a
> COMPONENT as argument, so it can't use the convenience methods macro.
>
Why do you need convenience methods for the internal accessor
%ADDITIONAL-INPUT-FILES ? Can't users who need convenience methods
(including internal functions) just use ADDITIONAL-INPUT-FILES, and
let *its* convenience methods do the trick?

>> 2.  I'll fix this, thanks.
>
> I don't fully understand.  I'm looking, and the APPEND call is in the
> scope of DO-ASDF-CACHE, AFAICT:
>
>   ;; Memoize input files.
>   (defmethod input-files :around (operation component)
>     (do-asdf-cache `(input-files ,operation ,component)
>       ;; get the additional input files, if any
>       (append (call-next-method)
>               ;; must come after the first, for other code that
>               ;; assumes the first will be the "key" file
>               (additional-input-files operation component))))
>
Oh, right. Somehow I misread that.

> If that's all, I can merge this into the plan branch, and then we should
> fix the ABCL issues.
>
Yes, it otherwise looks good.

I have a few tweaks to do afterwards: moving the 3.3.0 number past
your patches, some comment tweaks I have locally, and pushing back the
schedule of warnings to a further release (keep issuing only
style-warnings for deprecated functions, for now).

What about merging plan into master after I do that?

—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org
Any sufficiently unadvanced science fiction is indistinguishable from fantasy.