[asdf-devel] defsystem :version (:read-file-line ...) fails because :at key isn't recognized

Vsevolod Dyomkin vseloved at gmail.com
Thu Aug 15 10:58:32 UTC 2013


Basically, the problem is described in the message header.
Whereas :read-file-form option is used by ASDF itself, :read-file-line
isn't used and wasn't tested.

Attached is a patch with relevant test cases and fixes.

I would also suggest refactoring the code, because the code paths
for :read-file-form and :read-file-line are almost identical, but are
implemented in separate functions.

Best regards,

Vsevolod Dyomkin
skype, twitter: vseloved
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/asdf-devel/attachments/20130815/b13bb28e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_version_read_file_line.patch
Type: application/octet-stream
Size: 5150 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/asdf-devel/attachments/20130815/b13bb28e/attachment.obj>

More information about the asdf-devel mailing list