[asdf-devel] Running the tests: failures: ACL (alisp) and CMUCL

[Robert Goldman]

On 3/28/12 Mar 28 -10:30 AM, Robert Goldman wrote:
> ACL alisp:
> 
> ACL on MacOS X (8.2, 64-bit, updated yesterday) failed:
> 
> ;;; Writing fasl file /Users/rpg/lisp/asdf/tmp/fasls/alisp/asdf-tmp.fasl
> ;;; Fasl write complete
> Testsuite failed: ASDF compiled with warnings
> ; Exiting
> Compilation FAILED
> 
> 
> Looking upstream:
> 
> Warning: Can you please fix ASDF to not emit style-warnings? Got a
>          EXCL:COMPILER-UNREACHABLE-CODE-WARNING:
> cond clause (T :DEFAULT) is unreachable

I believe this is the location:

(defparameter *utf-8-external-format*
  (or
   #+(or abcl allegro clozure cmu ecl lispworks (and sbcl sb-unicode)
scl) :utf-8
   #+(and clisp unicode) charset:utf-8
   :default)
  "Default :external-format argument to pass for CL:OPEN.
For modern implementations, this should be UTF-8.
On legacy implementations, we may fall back on some 8-bit encoding,
with non-ASCII code points being read as several CL characters;
hopefully, if done consistently, it won't affect program behavior too
much.")

Proposed patch attached.

cheers,
r
-------------- next part --------------
>From 0f3964d30a3f9a4420af646d6e57faeae190fff9 Mon Sep 17 00:00:00 2001
From: "Robert P. Goldman" <rpgoldman at real-time.com>
Date: Wed, 28 Mar 2012 10:44:35 -0500
Subject: [PATCH] Fixed unreachable code in defparameter.

---
 asdf.lisp |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/asdf.lisp b/asdf.lisp
index 7eb0b81..344de6c 100644
--- a/asdf.lisp
+++ b/asdf.lisp
@@ -1296,6 +1296,7 @@ processed in order by OPERATE."))
   (or
    #+(or abcl allegro clozure cmu ecl lispworks (and sbcl sb-unicode) scl) :utf-8
    #+(and clisp unicode) charset:utf-8
+   #-(or (or abcl allegro clozure cmu ecl lispworks (and sbcl sb-unicode) scl) (and clisp unicode))
    :default)
   "Default :external-format argument to pass for CL:OPEN.
 For modern implementations, this should be UTF-8.
-- 
1.7.7.4