[asdf-devel] Pushed :here-directive topic branch

Faré fahree at gmail.com
Wed Nov 24 05:54:25 UTC 2010


On 23 November 2010 23:24, Robert Goldman <rpgoldman at sift.info> wrote:
> This branch has patches that add the :here directive to Faré's
> configuration DSL.  This allows for configuration files to have contents
> like:
>
> (:source-registry
>   (:tree (:here "src/lisp/"))
>   (:tree (:here "extlib/lisp"))
>   (:directory (:here "outlier/")))
>
I like the idea, and your patch looks mostly good, but
1- you should probably be using (default-directory) instead of
*default-pathname-defaults*
2- why not bind *default-pathname-defaults* instead of a new variable?
  NB: that would change the meaning of default-directory - may or may
not be a good thing.
3- you can wrap the whole body of process-source-registry (pathname
&key ...) in a
   (let ((*proper-variable* (pathname-directory-pathname pathname))) ...)

When you merge into master, don't forget to bump up the version number.

[ François-René ÐVB Rideau | Reflection&Cybernethics | http://fare.tunes.org ]
There are two distinct classes of men in the Nation, those who pay taxes
and those who receive and live upon the taxes. — Thomas Paine




More information about the asdf-devel mailing list