[armedbear-devel] Fixes to LispShell.java for 0.23.0

[Kevin Krouse]

Hi Frank,

Thanks for the patch.  I verified the build failure and just committed your
fix to svn!

Thanks for your help!
Kevin

On Sun, May 23, 2010 at 7:14 PM, Frank Pursel <purself at yahoo.com> wrote:

> All,
>
> I downloaded the latest version of J a couple of days ago (J version
> 0.23.0) and had some difficulties getting it to compile using
> java-6-sun's compiler version 1.6 update 20.  Here are the modifications
> I made to LispShell.java to get it to compile cleanly against a fresh build
> of
> the newest abcl (ver 0.19.1, though I don't think it matters):
>
> diff -c /home/fpp/src/tmp/j-0.23.0/src/org/armedbear/j/LispShell.java
> /home/fpp/src/j-0.23.0/src/org/armedbear/j/LispShell.java
> *** /home/fpp/src/tmp/j-0.23.0/src/org/armedbear/j/LispShell.java
> 2010-04-03
> 15:04:08.000000000 -0400
> --- /home/fpp/src/j-0.23.0/src/org/armedbear/j/LispShell.java   2010-05-22
> 18:42:29.963613502 -0400
> ***************
> *** 110,120 ****
>            }
>          else
>            {
> !             File lispHome = File.getInstance(Site.getLispHome());
>              if (lispHome == null)
>                return null; // FIXME Error message?
> !             File swankLoader = File.getInstance(lispHome,
> !                                                 "swank-loader.lisp");
>              if (swankLoader == null)
>                return null; // FIXME Error message?
>              if (shellCommand.indexOf("sbcl") >= 0
> --- 110,121 ----
>            }
>          else
>            {
> !           Pathname lispHome = (Pathname)Site.getLispHome();
>              if (lispHome == null)
>                return null; // FIXME Error message?
> !             File swankLoader = File.getInstance(
> !
> Pathname.mergePathnames(lispHome,
> !                                                                       new
> Pathname("swank-loader.lisp")));
>              if (swankLoader == null)
>                return null; // FIXME Error message?
>              if (shellCommand.indexOf("sbcl") >= 0
> ***************
> *** 902,908 ****
>                  sb.append(" -Xmx256M");
>                  if (Platform.isPlatformUnix())
>                    {
> !                     Pathname lispHome =
> org.armedbear.lisp.Site.getLispHome();
>                      if (lispHome != null)
>                        {
>                          sb.append(" -Xrs -Djava.library.path=");
> --- 903,909 ----
>                  sb.append(" -Xmx256M");
>                  if (Platform.isPlatformUnix())
>                    {
> !                     Pathname lispHome =
> (Pathname)org.armedbear.lisp.Site.getLispHome();
>                      if (lispHome != null)
>                        {
>                          sb.append(" -Xrs -Djava.library.path=");
>
> Diff finished.  Sun May 23 19:30:24 2010
>
> I hope it's helpful.  I was unable to get abcl to compile cleanly
> using the lisp build method.  It failed with messages telling me that
> it, variously, could not autoload load or that it could not load
> 'system'.  When I used ant I had no problems.
>
> Best wishes on an excellent project.
>
> Sincerely,
> Frank Pursel
>
>
>
>
> _______________________________________________
> armedbear-devel mailing list
> armedbear-devel at common-lisp.net
> http://common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/armedbear-devel/attachments/20100525/b50e1cc8/attachment.html>