[ansi-test-devel] Patch for syntax.escape test

Raymond Toy toy.raymond at gmail.com
Mon Apr 19 11:31:00 UTC 2010


On 4/18/10 10:59 PM, Sam Steingold wrote:
> On Sun, Apr 18, 2010 at 7:53 PM, Raymond Toy <toy.raymond at gmail.com> wrote:
>   
>> I would like to propose the following patch for a few of the
>> syntax.escape tests.  The tests currently compares the symbol name
>> against the given string.  Given that cmucl converts the string to NFC
>> form, the tests fails in a few cases.  This patch changes the test to
>> compare the symbol name against (find-symbol string).
>>     
> I don't like the change.
>   
Ok.  That's fine.
> I think the tests in question correctly check for a widely accepted contract.
> I think this is one of those cases where cmucl should just accept that
> its extensions make it fail some tests.
>   
Sure, there are other cases where cmucl will very likely not fix.
> (like clisp accepts that its extensions make it fails some tests; see
> clisp/utils/clispload.lsp).
> However, I am all for _adding_ a few new tests which would compare
> against (find-symbol string) instead of string which would pass on
> cmucl as well as other lisps.
>
>   
Yes, more tests are good, but I don't think it's worth it to have
essentially the same test.

Ray






More information about the ansi-test-devel mailing list