[usocket-devel] BUG: dangling references to split-sequence package

[Andy Chambers]

There is a dangling reference to split-sequence but split-sequence
itself is no longer
marked as a dependency in the defsystem spec.  This means that usocket cannot
currently be loaded using asdf unless split-sequence has already been loaded by
some other system.

The attached patch just replaces calls to
split-sequence:split-sequence with corresponding
calls to cl-utilities:split-sequence.

Also I think a few of the tests might need to be rewritten.  Both
before and after
applying this patch, 6 out of 15 tests fail for me.

Regards,
Andy Chambers

(format t "type: ~a   version: ~a"
		 (lisp-implementation-type)
		 (lisp-implementation-version))
type: SBCL   version: 1.0.18.debian

(usocket-test:run-usocket-tests)
Doing 15 pending tests of 15 tests total.
 USOCKET-TEST::MAKE-SOCKET.1 USOCKET-TEST::MAKE-SOCKET.2
#<USOCKET:UNSUPPORTED {B075EB9}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-NO-CONNECT.1 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS ('USOCKET:SOCKET-ERROR NIL)
                                            (USOCKET:SOCKET-CONNECT
                                             "127.0.0.0"
                                             USOCKET-TEST::+UNUSED-LOCAL-PORT+
                                             :TIMEOUT 0)
                                            T)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B075EB9}>.
#<USOCKET:UNSUPPORTED {B20A2B1}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-NO-CONNECT.2 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS ('USOCKET:SOCKET-ERROR NIL)
                                            (USOCKET:SOCKET-CONNECT
                                             #(127 0 0 0)
                                             USOCKET-TEST::+UNUSED-LOCAL-PORT+
                                             :TIMEOUT 0)
                                            T)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B20A2B1}>.
#<USOCKET:UNSUPPORTED {B3A5D81}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-NO-CONNECT.3 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS ('USOCKET:SOCKET-ERROR NIL)
                                            (USOCKET:SOCKET-CONNECT
                                             2130706432
                                             USOCKET-TEST::+UNUSED-LOCAL-PORT+
                                             :TIMEOUT 0)
                                            T)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B3A5D81}>.
#<USOCKET:UNSUPPORTED {B5461D9}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-FAILURE.1 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS
       ('USOCKET:NETWORK-UNREACHABLE-ERROR NIL)
       (USOCKET:SOCKET-CONNECT 2130706432
                               USOCKET-TEST::+UNUSED-LOCAL-PORT+ :TIMEOUT
                               0)
       :UNREACH)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B5461D9}>.
#<USOCKET:UNSUPPORTED {B9C8229}>
is a USOCKET:UNSUPPORTED.
Its slot values are
(:FEATURE USOCKET::TIMEOUT :CONTEXT USOCKET:SOCKET-CONNECT :MINIMUM NIL).
Test USOCKET-TEST::SOCKET-FAILURE.2 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS
       ('USOCKET:HOST-UNREACHABLE-ERROR NIL)
       (USOCKET:SOCKET-CONNECT USOCKET-TEST::+NON-EXISTING-HOST+ 80
                               :TIMEOUT 0)
       :UNREACH)
Expected value: NIL
Actual value: #<USOCKET:UNSUPPORTED {B9C8229}>.
 USOCKET-TEST::SOCKET-CONNECT.1 USOCKET-TEST::SOCKET-CONNECT.2
 USOCKET-TEST::SOCKET-CONNECT.3 USOCKET-TEST::SOCKET-STREAM.1
 USOCKET-TEST::SOCKET-NAME.1 USOCKET-TEST::SOCKET-NAME.2
 USOCKET-TEST::SOCKET-NAME.3
Test USOCKET-TEST::SOCKET-NAME.4 failed
Form: (USOCKET-TEST::WITH-CAUGHT-CONDITIONS (NIL NIL)
                                            (LET ((USOCKET-TEST::SOCK
                                                   (USOCKET:SOCKET-CONNECT

USOCKET-TEST::+COMMON-LISP-NET+
                                                    80)))
                                              (UNWIND-PROTECT
                                                  (USOCKET:GET-LOCAL-ADDRESS
                                                   USOCKET-TEST::SOCK)
                                                (USOCKET:SOCKET-CLOSE
                                                 USOCKET-TEST::SOCK))))
Expected value: #(192 168 1 25)
Actual value: #(192 168 0 3).
6 out of 15 total tests failed: USOCKET-TEST::SOCKET-NO-CONNECT.1,
   USOCKET-TEST::SOCKET-NO-CONNECT.2, USOCKET-TEST::SOCKET-NO-CONNECT.3,
   USOCKET-TEST::SOCKET-FAILURE.1, USOCKET-TEST::SOCKET-FAILURE.2,
   USOCKET-TEST::SOCKET-NAME.4.
NIL
CL-USER>

-- 
----
Andy Chambers
Formedix Ltd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: replace-cl-utilities.patch
Type: text/x-patch
Size: 959 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/usocket-devel/attachments/20100109/dbfb5f07/attachment.bin>