[usocket-devel] patches for usocket mcl backend and tests

[james anderson]

On 2010-01-04, at 08:52 , Chun Tian (binghe) wrote:

> Hi, James
>
> Thanks, most of your patch has been committed.

that's nice. from what i can see, there's still (at least) one  
function missing: something to get the local ip number. mcl calls it  
local-interface-ip-nuumber, clozure has a list of ip interface  
descriptors from which one could choose (see ccl::%get-ip-interfaces).

>
> The only left part is the "fully qualified system name". Why it  
> works? Which version of ASDF support that?
>

i wasn't expecting they would work elsewhere. i do things that way  
since, at this point there are over 200 .asd definitions in my source  
tree and it's not sensible to track each with it's own entry in some  
registry. in order to avoid that, i implemented a hierarchical search  
function and add it to the asdf system search functions. i sent gary  
king a version of it a while ago, but he didn't think it worth while,  
so i just make local changes. i read lately, that they're now  
considering something similar, so i may try again.


> Regards,
>
> Chun Tian (binghe)
>
>> good evening;
>>
>> please find attached patches for the mcl back-end and the tests.  
>> the system names follow from the local conventions for asdf  
>> systems, but the other changes should be generally useful.
>>
>> given these changes mcl 5.2 passes all 15. i cross-checked with  
>> openmcl ("Version 1.3-r11936  (DarwinPPC32)") which succeded as well.
>>
>> * test/test-usocket.lisp
>> : added timeout arguments to the no-connect tests, as both mcl and  
>> openmcl otherwise hang
>> : added mcl to the caught conditions for failure tests
>> : wrapped typep tests to force t/nil
>> : corrected #\newline to be #\linefeed
>> : added a +local-ip+ variable
>>
>> * test/usocket-test.asd
>> :  changed dependencies to be fully qualified
>>
>> * usocket.asd
>> : modified dependency to use cl-utilities (by fully qualified  
>> system name)
>>
>> * backend/mcl.lisp
>> : handle-condition : corrected to formulate the error argument as  
>> required for the respective error class
>> : socket-connect : reinstated with-mapped-conditions
>> : socket-listen : reinstated with-mapped-conditions
>> : socket-accept : reinstated with-mapped-conditions
>> : %*-wait operators : added no-op versions
>>
>>
>>
>> <diff-20100103.txt>_______________________________________________
>> usocket-devel mailing list
>> usocket-devel at common-lisp.net
>> http://common-lisp.net/cgi-bin/mailman/listinfo/usocket-devel
>