From sky at viridian-project.de  Wed Nov 19 13:32:41 2008
From: sky at viridian-project.de (Leslie P. Polzer)
Date: Wed, 19 Nov 2008 14:32:41 +0100 (CET)
Subject: [tinaa-devel] Bug with MAKE-ITERATOR
Message-ID: <64491.88.73.195.175.1227101561.squirrel@mail.stardawn.org>

Current Tinaa fails to build Weblocks' documentation.

Log and a quick fix that doesn't handle the real problem
are attached.

Maybe you could spare some time to fix it, Gary?

-- 
LinkedIn Profile: http://www.linkedin.com/in/polzer
Xing Profile: https://www.xing.com/profile/LeslieP_Polzer
Blog: http://blog.viridian-project.de/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bt.txt
URL: <https://mailman.common-lisp.net/pipermail/tinaa-devel/attachments/20081119/e4076304/attachment.txt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tinaa-make-iterator.patch
Type: text/x-patch
Size: 2054 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/tinaa-devel/attachments/20081119/e4076304/attachment.bin>

From gwking at metabang.com  Wed Nov 19 22:54:11 2008
From: gwking at metabang.com (Gary King)
Date: Wed, 19 Nov 2008 17:54:11 -0500
Subject: [tinaa-devel] Bug with MAKE-ITERATOR
In-Reply-To: <64491.88.73.195.175.1227101561.squirrel@mail.stardawn.org>
References: <64491.88.73.195.175.1227101561.squirrel@mail.stardawn.org>
Message-ID: <76EBC796-9DF9-41DE-811D-02B174133B93@metabang.com>

Hi Leslie,

Thanks for the bug report. I will try (very, very hard!) to look at it  
and fix it tomorrow or (more likely) this weekend.

On Nov 19, 2008, at 8:32 AM, Leslie P. Polzer wrote:

> Current Tinaa fails to build Weblocks' documentation.
>
> Log and a quick fix that doesn't handle the real problem
> are attached.
>
> Maybe you could spare some time to fix it, Gary?
>
> -- 
> LinkedIn Profile: http://www.linkedin.com/in/polzer
> Xing Profile: https://www.xing.com/profile/LeslieP_Polzer
> Blog: http://blog.viridian-project.de/<bt.txt><tinaa-make- 
> iterator.patch>_______________________________________________
> tinaa-devel mailing list
> tinaa-devel at common-lisp.net
> http://common-lisp.net/cgi-bin/mailman/listinfo/tinaa-devel

--
Gary Warren King, metabang.com
Cell: (413) 559 8738
Fax: (206) 338-4052
gwkkwg on Skype * garethsan on AIM







From gwking at metabang.com  Sat Nov 22 13:09:35 2008
From: gwking at metabang.com (Gary King)
Date: Sat, 22 Nov 2008 08:09:35 -0500
Subject: [tinaa-devel] tinaa dependency
In-Reply-To: <200811220657.mAM6vI9v001759@nitro.isi.edu>
References: <200811220657.mAM6vI9v001759@nitro.isi.edu>
Message-ID: <BAA3F821-8A7D-4BF5-9CFA-9ADC0E5EC4EC@metabang.com>

(cc'd to list)

Hi Andrew,

I will look into this today.

thanks for the report,

On Nov 22, 2008, at 1:57 AM, Andrew Philpot wrote:

>
> tinaa 0.5.6 seems to need a definition for directory-pathname-p.
>
> I don't find such in the tree.
>
> There is one in cl-fad, but that's not a known dependency.  I will  
> use it for
> now.  Any hints?
>
> Thanks,
> Andrew
>
>

--
Gary Warren King, metabang.com
Cell: (413) 559 8738
Fax: (206) 338-4052
gwkkwg on Skype * garethsan on AIM







From gwking at metabang.com  Sat Nov 22 21:02:42 2008
From: gwking at metabang.com (Gary King)
Date: Sat, 22 Nov 2008 16:02:42 -0500
Subject: [tinaa-devel] Bug with MAKE-ITERATOR
In-Reply-To: <64491.88.73.195.175.1227101561.squirrel@mail.stardawn.org>
References: <64491.88.73.195.175.1227101561.squirrel@mail.stardawn.org>
Message-ID: <248ABA36-F1CB-47DF-97F0-900E9B02541F@metabang.com>

Hi Leslie,

I was just looking at this and I'm confused.

I'm stumbling through getting weblocks installed (far too difficult.  
sigh) but I don't get the error you are reporting using Allegro CL. (I  
still can't get weblocks to install using SBCL because I get all of  
these such and such is not a valid logical pathname errors).

In any case , the error you saw seems to be caused by a call to make- 
iterator with `nil` as its parameter. This leaves make-iterator  
feeling sad. But I don't understand how it happened since the make- 
iterator is guarded by a `awhen` that should mean that it is only  
executed if `it` isn't `nil`. Your patch certainly prevents the error  
but it shouldn't be needed. After all, the expansion is something like:

>
> (let ((it (default-initargs (instance part))))
>   (when it
>     (html ((:div :class "table-summary") (:h3 "Default initargs")
>            ((:table :id "default-initargs")
>             (let ((iterator (make-iterator it)) (count 1))
>
> ...
>
> ))

Can you see how the awhen expands in your environment; perhaps that's  
where the problem is actually occurring. I'd certainly like to get to  
the bottom of this.

I could also alter make-iterator so that it just returns nil if passed  
nil -- which makes a sort of sense. But before I do that, I'd like to  
understand what is going wrong here.

thanks,
--
Gary Warren King, metabang.com
Cell: (413) 559 8738
Fax: (206) 338-4052
gwkkwg on Skype * garethsan on AIM







From sky at viridian-project.de  Sun Nov 23 00:24:12 2008
From: sky at viridian-project.de (Leslie P. Polzer)
Date: Sun, 23 Nov 2008 01:24:12 +0100 (CET)
Subject: [tinaa-devel] Bug with MAKE-ITERATOR
In-Reply-To: <248ABA36-F1CB-47DF-97F0-900E9B02541F@metabang.com>
References: <64491.88.73.195.175.1227101561.squirrel@mail.stardawn.org>
	<248ABA36-F1CB-47DF-97F0-900E9B02541F@metabang.com>
Message-ID: <62820.88.73.199.124.1227399852.squirrel@mail.stardawn.org>


Hi Gary,

> I was just looking at this and I'm confused.

Thanks for taking time to look at it, I appreciate it.


> I'm stumbling through getting weblocks installed (far too difficult.
> sigh)

Try clbuild, you just have to do "install weblocks" with it.


> but I don't get the error you are reporting using Allegro CL. (I
> still can't get weblocks to install using SBCL because I get all of
> these such and such is not a valid logical pathname errors).

Maybe you're using a stale version of Weblocks.

We use and test it every day with SBCL.


> In any case , the error you saw seems to be caused by a call to make-
> iterator with `nil` as its parameter. This leaves make-iterator
> feeling sad. But I don't understand how it happened since the make-
> iterator is guarded by a `awhen` that should mean that it is only
> executed if `it` isn't `nil`. Your patch certainly prevents the error
> but it shouldn't be needed. After all, the expansion is something like:
>
>>
>> (let ((it (default-initargs (instance part))))
>>   (when it
>>     (html ((:div :class "table-summary") (:h3 "Default initargs")
>>            ((:table :id "default-initargs")
>>             (let ((iterator (make-iterator it)) (count 1))
>>
>> ...
>>
>> ))
>
> Can you see how the awhen expands in your environment; perhaps that's
> where the problem is actually occurring. I'd certainly like to get to
> the bottom of this.

I think AWHEN is fine.

The problem is not MAKE-ITERATOR being called with NIL, but
MAKE-ITERATOR *returning* NIL.

The patch works around exactly that. I suspect some problem
with DYNAMIC-CLASS but I don't know enough of it (and
cl-containers and probably more of your stuff) to get at it
in reasonable time...

  Leslie

-- 
LinkedIn Profile: http://www.linkedin.com/in/polzer
Xing Profile: https://www.xing.com/profile/LeslieP_Polzer
Blog: http://blog.viridian-project.de/




From sky at viridian-project.de  Sun Nov 23 00:29:02 2008
From: sky at viridian-project.de (Leslie P. Polzer)
Date: Sun, 23 Nov 2008 01:29:02 +0100 (CET)
Subject: [tinaa-devel] tinaa dependency
In-Reply-To: <BAA3F821-8A7D-4BF5-9CFA-9ADC0E5EC4EC@metabang.com>
References: <200811220657.mAM6vI9v001759@nitro.isi.edu>
	<BAA3F821-8A7D-4BF5-9CFA-9ADC0E5EC4EC@metabang.com>
Message-ID: <63070.88.73.199.124.1227400142.squirrel@mail.stardawn.org>


> On Nov 22, 2008, at 1:57 AM, Andrew Philpot wrote:
>
>>
>> tinaa 0.5.6 seems to need a definition for directory-pathname-p.
>>
>> I don't find such in the tree.
>>
>> There is one in cl-fad, but that's not a known dependency.  I will
>> use it for
>> now.  Any hints?

Looks like your Metatilities are outdated.


-- 
LinkedIn Profile: http://www.linkedin.com/in/polzer
Xing Profile: https://www.xing.com/profile/LeslieP_Polzer
Blog: http://blog.viridian-project.de/




From gwking at metabang.com  Sun Nov 23 01:18:32 2008
From: gwking at metabang.com (Gary King)
Date: Sat, 22 Nov 2008 20:18:32 -0500
Subject: [tinaa-devel] tinaa dependency
In-Reply-To: <63070.88.73.199.124.1227400142.squirrel@mail.stardawn.org>
References: <200811220657.mAM6vI9v001759@nitro.isi.edu>
	<BAA3F821-8A7D-4BF5-9CFA-9ADC0E5EC4EC@metabang.com>
	<63070.88.73.199.124.1227400142.squirrel@mail.stardawn.org>
Message-ID: <59C997D1-289F-485D-AB5B-CEFFD1423D77@metabang.com>

Hi Andrew,

As Leslie pointed out, the problem is that `directory-pathname-p ` is  
included in metatilites-base (mostly to reduce dependencies). I'm not  
quite sure when I changed this but it was a while ago; the current  
metatilites-base is at version 0.6.6.

Please let me if this works for you,

thanks,

On Nov 22, 2008, at 7:29 PM, Leslie P. Polzer wrote:

>
>> On Nov 22, 2008, at 1:57 AM, Andrew Philpot wrote:
>>
>>>
>>> tinaa 0.5.6 seems to need a definition for directory-pathname-p.
>>>
>>> I don't find such in the tree.
>>>
>>> There is one in cl-fad, but that's not a known dependency.  I will
>>> use it for
>>> now.  Any hints?
>
> Looks like your Metatilities are outdated.

--
Gary Warren King, metabang.com
Cell: (413) 559 8738
Fax: (206) 338-4052
gwkkwg on Skype * garethsan on AIM