I seem to be able to reproduce it like this:<div><br></div><div> - Load a page.</div><div><br></div><div> - Reload twice in quick succession. (I hit Command-R twice as fast as I can.)</div><div><br></div><div> - Wait about 15-20 seconds.</div>
<div><br></div><div>At that point, three debugger buffers will pop up, all with the same socket timeout error. I've tried this on Chrome and Firefox, with SBCL 1.0.41 as my Lisp. I've had the server on both OS X and Debian.</div>
<div><br></div><div>-Peter</div><div><br><br><div class="gmail_quote">On Mon, Aug 23, 2010 at 9:42 PM, Hans Hübner <span dir="ltr"><<a href="mailto:hans.huebner@gmail.com">hans.huebner@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Peter,<br>
<br>
before moving forward with your patch, I tried to reproduce the wrong<br>
behavior and failed. From your report, I would have expected that if<br>
I set *CATCH-ERRORS-P* to NIL, open a connection to Hunchentoot and<br>
then wait, I'd be sent to the debugger. This does not seem to be the<br>
case, even when I send the initial request line.<br>
<br>
Even though I'd think that errors should be intercepted only while<br>
reading the initial request line, the current behavior seems to be<br>
acceptable. Could it be that the timeouts that you see and find<br>
disturbing are coming from somewhere else? Can you provide a way to<br>
reproduce the issue?<br>
<br>
Thanks,<br>
<font color="#888888">Hans<br>
</font><div><div></div><div class="h5"><br>
On Tue, Aug 24, 2010 at 01:45, Peter Seibel <<a href="mailto:peter@gigamonkeys.com">peter@gigamonkeys.com</a>> wrote:<br>
> So the problem seems to be in READ-INITIAL-REQUEST-LINE where HANDLER-CASE*<br>
> lets MAYBE-INVOKE-DEBUGGER handle the condition before the cases of the<br>
> HANDLER-CASE.<br>
> I may well be missing something, but it seems like mabye HANDLER-CASE*<br>
> should be changed as in the following patch so MAYBE-INVOKE-DEBUGGER is only<br>
> invoked for unhandled conditions.<br>
> -Peter<br>
> --- conditions.lisp 2010-08-23 16:29:48.000000000 -0700<br>
> +++ fixed-conditions.lisp 2010-08-23 16:43:26.000000000 -0700<br>
> @@ -112,8 +112,8 @@<br>
><br>
> (defmacro handler-case* (expression &rest clauses)<br>
> "Like HANDLER-CASE, but observes *CATCH-ERRORS-P*."<br>
> - `(handler-case (with-debugger ,expression)<br>
> - ,@clauses))<br>
> + `(with-debugger<br>
> + (handler-case ,expression ,@clauses)))<br>
><br>
> (defun get-backtrace ()<br>
> "Returns a string with a backtrace of what the Lisp system thinks is<br>
><br>
> On Sun, Aug 22, 2010 at 11:27 PM, Hans Hübner <<a href="mailto:hans.huebner@gmail.com">hans.huebner@gmail.com</a>><br>
> wrote:<br>
>><br>
>> On Mon, Aug 23, 2010 at 07:26, Peter Seibel <<a href="mailto:peter@gigamonkeys.com">peter@gigamonkeys.com</a>> wrote:<br>
>> > If I set *CATCH-ERRORS-P* to NIL, is it expected/desired behavior that<br>
>> > the<br>
>> > timeout-errors generated when (I think) the client disconnects without<br>
>> > making a full request or some such, will land you in the debugger?<br>
>><br>
>> This is a bug. Timeouts that occur while Hunchentoot is waiting for a<br>
>> new request should always be ignored. Timeouts that occur when a<br>
>> partial request has been request has been received _should_ be<br>
>> intercepted, though, as those are not part of a normal exchange.<br>
>><br>
>> I've added the issue to our bug tracker.<br>
>><br>
>> -Hans<br>
>><br>
>> _______________________________________________<br>
>> tbnl-devel site list<br>
>> <a href="mailto:tbnl-devel@common-lisp.net">tbnl-devel@common-lisp.net</a><br>
>> <a href="http://common-lisp.net/mailman/listinfo/tbnl-devel" target="_blank">http://common-lisp.net/mailman/listinfo/tbnl-devel</a><br>
><br>
><br>
><br>
> --<br>
> Peter Seibel<br>
> <a href="http://www.codequarterly.com/" target="_blank">http://www.codequarterly.com/</a><br>
><br>
> _______________________________________________<br>
> tbnl-devel site list<br>
> <a href="mailto:tbnl-devel@common-lisp.net">tbnl-devel@common-lisp.net</a><br>
> <a href="http://common-lisp.net/mailman/listinfo/tbnl-devel" target="_blank">http://common-lisp.net/mailman/listinfo/tbnl-devel</a><br>
><br>
<br>
_______________________________________________<br>
tbnl-devel site list<br>
<a href="mailto:tbnl-devel@common-lisp.net">tbnl-devel@common-lisp.net</a><br>
<a href="http://common-lisp.net/mailman/listinfo/tbnl-devel" target="_blank">http://common-lisp.net/mailman/listinfo/tbnl-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Peter Seibel<br><a href="http://www.codequarterly.com/" target="_blank">http://www.codequarterly.com/</a><br>
</div>