[hunchentoot-devel] Patch from the past: Ref. [c.2009-07] Hunchentoot effective DOS-attack

[Hans Hübner]

Hi Mathieu,

I have mined the Subversion repository for the commits that you
referenced, and I found them to represent this patch:

Index: taskmaster.lisp
===================================================================
--- taskmaster.lisp	(revision 4427)
+++ taskmaster.lisp	(revision 4435)
@@ -127,9 +127,21 @@

 #-:lispworks
 (defmethod handle-incoming-connection ((taskmaster
one-thread-per-connection-taskmaster) socket)
-  (bt:make-thread (lambda ()
-                    (process-connection (taskmaster-acceptor
taskmaster) socket))
-                  :name (format nil "Hunchentoot worker \(client:
~A)" (client-as-string socket))))
+  ;; We are handling all conditions here as we want to make sure that
+  ;; the acceptor process never crashes while trying to create a
+  ;; worker thread.  One such problem exists in
+  ;; GET-PEER-ADDRESS-AND-PORT which can signal socket conditions on
+  ;; some platforms in certain situations.
+  (handler-case
+      (bt:make-thread (lambda ()
+                        (process-connection (taskmaster-acceptor
taskmaster) socket))
+                      :name (format nil "Hunchentoot worker \(client:
~A)" (client-as-string socket)))
+
+    (error (cond)
+      ;; Need to bind *ACCEPTOR* so that LOG-MESSAGE can do its work.
+      (let ((*acceptor* (taskmaster-acceptor taskmaster)))
+        (log-message *lisp-errors-log-level*
+                     "Error while creating worker thread for new
incoming connection: ~A" cond)))))

 ;; LispWorks implementation

Now, the patch actually does not apply, but it was on trunk and has
been evolved into the current version:

https://github.com/edicl/hunchentoot/blob/master/taskmaster.lisp#L355

If I understand you correctly, you say that the code does not work.
Can you somehow provide a way to reproduce the problem?

Thanks,
Hans

On Wed, Aug 15, 2012 at 3:29 PM, Mathieu Lemoine <mlemoine at mentel.com> wrote:
> Hi,
>
> I am currently hitting the problem described in the following thread:
> http://lists.common-lisp.net/pipermail/tbnl-devel/2009-July/004768.html
>
> I'm using SBCL 1.0.58 with hunchentoot 1.2.3 and usocket 0.5.5 (both from
> quicklisp).
>
> I understand the long-term fix will be some hard work. However, in this
> thread, Hans is referencing a few diff hunks :
>
> http://bknr.net/trac/changeset/4430?format=diff&new=4430
> http://bknr.net/trac/changeset/4434?format=diff&new=4434
> http://bknr.net/trac/changeset/4435?format=diff&new=4435
>
> Since the old trac is not working anymore, could it be possible to either
> point me toward the equivalent commits in the github repository or the
> content of these patches.
>
> By the way, Peter, if you're still around, did you need to apply only 4435
> or both this and 4434 in order to solve the second issue (unbound variable
> on *acceptor*)?
>
> If anybody has information with respect to these issues, including the
> corresponding bug report in usocket, so I can do some follow up with them,
> it would be greatly appreciated.
>
> Thanks in advance for your help and time.
>
> Mathieu.
>
> _______________________________________________
> tbnl-devel site list
> tbnl-devel at common-lisp.net
> http://common-lisp.net/mailman/listinfo/tbnl-devel