[hunchentoot-devel] PATCH: simplify debugging of remote servers

[Hans Hübner]

Hi Andrey,

I like your patch, but can you enhance it so that it works when swank
is not available?

Some review comments:

If you could change

(find-symbol "ADD-HOOK" :swank)

to something like

(find-symbol (string '#:add-hook) :swank)

it'd be nicer towards users of non-standard readtable case settings.

We generally follow the rule to always use the most specific operator,
so if you could change the LOOP in KILL-ALL-DEBUGGING-THREADS to
DOLIST, it'd be more in line with the rest of the code.  If you really
love loop, you could remove the do from the LOOP and use the WHEN LOOP
clause

Thanks again,
Hans

On Sun, Mar 7, 2010 at 02:15, Andrey Moskvitin <archimag at gmail.com> wrote:
> I know that for production installations, it is not advisable to have
> *CATCH-ERRORS-P*  to be set to NIL. But it is often necessary to
> debug of remote server. Attached is my patch that simplifies this
> process. It limits the number of active calls invoke-debugger and
> destroys debugging threads after closing the connection with a
> swank-server.
>
> Andrey
>
> _______________________________________________
> tbnl-devel site list
> tbnl-devel at common-lisp.net
> http://common-lisp.net/mailman/listinfo/tbnl-devel
>