<div dir="ltr"><div><div><div>Applied here: <a href="https://github.com/slime/slime/commit/81017fbc9e622d3f0f9fa4b35e35f9ab8c4d381b">https://github.com/slime/slime/commit/81017fbc9e622d3f0f9fa4b35e35f9ab8c4d381b</a><br></div><div><br></div>Thanks!<br></div>Luís<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Feb 8, 2018 at 4:22 AM Douglas Katzman <<a href="mailto:dougk@google.com">dougk@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi,</div><div><br></div><div>Please apply this diff. There are multiple problems with the existing code.<br></div><div>* it seems to believe that DISASSEMBLE-CODE-COMPONENT only works on with non-null %code-debug-info. That's not true; it works on any code object. So depending on your standards, it's excessively wordy to just plain wrong.</div><div><br></div><div>* <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">(ash (sb-kernel:%code-code-size o) sb-vm:word-shift) causes buffer overrun</span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">* sb-disassem::align can not be called</span></div><div><br></div><div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">See <a href="https://bugs.launchpad.net/sbcl/+bug/1748041" target="_blank">https://bugs.launchpad.net/sbcl/+bug/1748041</a></div></div><div>Thanks</div><div>Doug</div><div><br></div><div><div>--- a/swank/sbcl.lisp</div><div>+++ b/swank/sbcl.lisp</div><div>@@ -1613,18 +1613,7 @@ stack."</div><div>          append (label-value-line i (sb-kernel:code-header-ref o i)))</div><div>    `("Code:" (:newline)</div><div>              , (with-output-to-string (s)</div><div>-                 (cond ((sb-kernel:%code-debug-info o)</div><div>-                        (sb-disassem:disassemble-code-component o :stream s))</div><div>-                       (t</div><div>-                        (sb-disassem:disassemble-memory</div><div>-                         (sb-disassem::align</div><div>-                          (+ (logandc2 (sb-kernel:get-lisp-obj-address o)</div><div>-                                       sb-vm:lowtag-mask)</div><div>-                             (* sb-vm:code-constants-offset</div><div>-                                sb-vm:n-word-bytes))</div><div>-                          (ash 1 sb-vm:n-lowtag-bits))</div><div>-                         (ash (sb-kernel:%code-code-size o) sb-vm:word-shift)</div><div>-                         :stream s)))))))</div><div>+                 (sb-disassem:disassemble-code-component o :stream s)))))</div></div><div><br></div></div>
</blockquote></div>