From dougk at google.com  Wed Dec 16 17:31:34 2020
From: dougk at google.com (Douglas Katzman)
Date: Wed, 16 Dec 2020 12:31:34 -0500
Subject: syntax error in recent Slime commit
Message-ID: <CAOrNaswCj+SB+qonB=xVXgOUU4a5UXOsYCKPmRK9F2r+8ROtBQ@mail.gmail.com>

This change causes a malformed let in an older SBCL that has both a
compatibility accessor (%code-entry-points) and the preferred accessor
(%code-entry-point).
It works in new SBCL which only has the new, and very old SBCL which only
has the old, but not in the interim releases which had both.

commit 53badd278bf5ac36922d7b417f44e1c21e724547

Author: Stas Boukarev <stassats at gmail.com>

Date:   Tue Dec 15 01:38:46 2020 +0300


    No more sb-kernel:%code-entry-points.


*diff --git a/contrib/swank-sprof.lisp b/contrib/swank-sprof.lisp*

*index 675240ff..9c640ec3 100644*

*--- a/contrib/swank-sprof.lisp*

*+++ b/contrib/swank-sprof.lisp*

@@ -138,7 +138,10 @@

          (debug-info (sb-sprof::node-debug-info node)))

     (or (when (typep debug-info 'sb-di::compiled-debug-fun)

           (let* ((component (sb-di::compiled-debug-fun-component
debug-info))

-                 (function (sb-kernel::%code-entry-points component)))

+                 (function #+#.(swank/backend:with-symbol
'%code-entry-points 'sb-kernel)

+                           (sb-kernel::%code-entry-points component)

+                           #+#.(swank/backend:with-symbol
'%code-entry-point 'sb-kernel)

+                           (sb-kernel:%code-entry-point component 0)))

             (when function

               (find-source-location function))))

         `(:error "No source location available"))))

d
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/slime-devel/attachments/20201216/9906f976/attachment.html>

From stassats at gmail.com  Wed Dec 16 17:40:11 2020
From: stassats at gmail.com (Stas Boukarev)
Date: Wed, 16 Dec 2020 20:40:11 +0300
Subject: syntax error in recent Slime commit
In-Reply-To: <CAOrNaswCj+SB+qonB=xVXgOUU4a5UXOsYCKPmRK9F2r+8ROtBQ@mail.gmail.com>
References: <CAOrNaswCj+SB+qonB=xVXgOUU4a5UXOsYCKPmRK9F2r+8ROtBQ@mail.gmail.com>
Message-ID: <CAF63=1113Pm9POgJmS_mm8QXcQpfwsvRt+HCR1Rp-VPCTL_dHQ@mail.gmail.com>

Fixed, thanks.

On Wed, Dec 16, 2020 at 8:31 PM Douglas Katzman <dougk at google.com> wrote:

> This change causes a malformed let in an older SBCL that has both a
> compatibility accessor (%code-entry-points) and the preferred accessor
> (%code-entry-point).
> It works in new SBCL which only has the new, and very old SBCL which only
> has the old, but not in the interim releases which had both.
>
> commit 53badd278bf5ac36922d7b417f44e1c21e724547
>
> Author: Stas Boukarev <stassats at gmail.com>
>
> Date:   Tue Dec 15 01:38:46 2020 +0300
>
>
>     No more sb-kernel:%code-entry-points.
>
>
> *diff --git a/contrib/swank-sprof.lisp b/contrib/swank-sprof.lisp*
>
> *index 675240ff..9c640ec3 100644*
>
> *--- a/contrib/swank-sprof.lisp*
>
> *+++ b/contrib/swank-sprof.lisp*
>
> @@ -138,7 +138,10 @@
>
>           (debug-info (sb-sprof::node-debug-info node)))
>
>      (or (when (typep debug-info 'sb-di::compiled-debug-fun)
>
>            (let* ((component (sb-di::compiled-debug-fun-component
> debug-info))
>
> -                 (function (sb-kernel::%code-entry-points component)))
>
> +                 (function #+#.(swank/backend:with-symbol
> '%code-entry-points 'sb-kernel)
>
> +                           (sb-kernel::%code-entry-points component)
>
> +                           #+#.(swank/backend:with-symbol
> '%code-entry-point 'sb-kernel)
>
> +                           (sb-kernel:%code-entry-point component 0)))
>
>              (when function
>
>                (find-source-location function))))
>
>          `(:error "No source location available"))))
>
> d
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/slime-devel/attachments/20201216/8bd14706/attachment.html>