[patch] another fix for find-definition in the REPL buffer

João Távora joaotavora at gmail.com
Wed Jul 10 07:29:02 UTC 2013


I found and fixed another annoyance when trying to M-. on a
presentation in the REPL
buffer with the slime-fancy contrib enabled. This appears to be
traceable to the slime-presentations
contrib, so I'm cc'ing the authors

The function I changed must return nil on failure so as not to break
the `run-hooks-until-success'
logic of `slime-edit-definition-hooks'.

diff --git a/contrib/slime-presentations.el b/contrib/slime-presentations.el
index a462669..fd0fd63 100644
--- a/contrib/slime-presentations.el
+++ b/contrib/slime-presentations.el
@@ -401,11 +401,12 @@ Also return the start position, end position,
and buffer of the presentation."
 	 (location (slime-eval `(swank:find-definition-for-thing
 				 (swank:lookup-presented-object
 				  ',(slime-presentation-id presentation))))))
+    (unless (eq (car location) :error)
     (slime-edit-definition-cont
      (and location (list (make-slime-xref :dspec `(,presentation-string)
 					  :location location)))
      presentation-string
-     where)))
+       where))))


BTW, I wonder if providing these patches with full changelog and ready
to commit would somehow
speed up the analysis/integration

-- 
João Távora



More information about the slime-devel mailing list