[slime-devel] patch to prevent warning running under Allegro Common Lisp

Gary King gwking at metabang.com
Wed Sep 10 12:37:39 UTC 2008


Here is a diff -c; let me know if there is a better way to send this  
and/or a right person to send it to.

thanks,

Index: ChangeLog
===================================================================
RCS file: /project/slime/cvsroot/slime/ChangeLog,v
retrieving revision 1.1495
diff -c -r1.1495 ChangeLog
*** ChangeLog	9 Sep 2008 23:29:44 -0000	1.1495
--- ChangeLog	10 Sep 2008 12:34:23 -0000
***************
*** 1,5 ****
--- 1,14 ----
   2008-09-10  Tobias C. Rittweiler  <tcr at freebits.de>

+ 	* ChangeLog (fspec-definition-locations): add declare ignores
+ 	to prevent warnings
+
+ 	(emacs-inspect): remove first definition on function since it
+ 	was being overwritten by the next one. Wrap the method on t with
+ 	a excl:without-redefinition-warnings to prevent warning.
+ 	
+ 2008-09-10  Tobias C. Rittweiler  <tcr at freebits.de>
+
   	* swank-backend.lisp (*gray-stream-symbols*): Comment out
   	STREAM-FILE-POSITION.

Index: swank-allegro.lisp
===================================================================
RCS file: /project/slime/cvsroot/slime/swank-allegro.lisp,v
retrieving revision 1.110
diff -c -r1.110 swank-allegro.lisp
*** swank-allegro.lisp	11 Aug 2008 07:40:23 -0000	1.110
--- swank-allegro.lisp	10 Sep 2008 12:34:26 -0000
***************
*** 402,413 ****
--- 402,415 ----
      ((and (listp fspec)
            (eql (car fspec) :top-level-form))
       (destructuring-bind (top-level-form file &optional position)  
fspec
+       (declare (ignore top-level-form))
         (list
          (list (list nil fspec)
                (make-location (list :buffer file)
                               (list :position position t))))))
      ((and (listp fspec) (eq (car fspec) :internal))
       (destructuring-bind (_internal next _n) fspec
+       (declare (ignore _internal _n))
         (fspec-definition-locations next)))
      (t
       (let ((defs (excl::find-source-file fspec)))
***************
*** 570,575 ****
--- 572,580 ----

   ;;;; Inspecting

+ #+no
+ ;; use the one below that calls allegro-inspect instead
+ ;;?? remove
   (defmethod emacs-inspect ((f function))
             (append
              (label-value-line "Name" (function-name f))
***************
*** 578,585 ****
                (when doc
                  `("Documentation:" (:newline) ,doc)))))

   (defmethod emacs-inspect ((o t))
!   (allegro-inspect o))

   (defmethod emacs-inspect ((o function))
     (allegro-inspect o))
--- 583,591 ----
                (when doc
                  `("Documentation:" (:newline) ,doc)))))

+ (excl:without-redefinition-warnings
   (defmethod emacs-inspect ((o t))
!   (allegro-inspect o)))

   (defmethod emacs-inspect ((o function))
     (allegro-inspect o))


--
Gary Warren King, metabang.com
Cell: (413) 559 8738
Fax: (206) 338-4052
gwkkwg on Skype * garethsan on AIM







More information about the slime-devel mailing list