[slime-devel] Re: [PATCH] Re: RFC for completion behaviour

[Tobias C. Rittweiler]

"Tobias C. Rittweiler" <tcr at freebits.de> writes:

> [...]

I've been bitten by a bug in the older SBCL version I use that prevented
me from seeing what a shenanigan I had straying in my code; here's a
better patch:


2007-04-28  Tobias C. Rittweiler <INSERT-EMAIL-HERE>

	Removed support for completing to the longest compound pre- and
	suffix with the default completion method (C-c TAB, or just TAB on
	the REPL), because it has been causing trouble all the time, but
	didn't offer any real advantage besides niftiness. E.g.:

	    previous behaviour: 

	      asdf:*com TAB => asdf:*compile-file--behaviour*

	    now simply:

	      asdf:*com TAB => asdf:*compile-file-

	For discussing on this subject, please see the mail with
	message-id <87y7l53lch.fsf at freebits.de> that was posted to
	slime-devel 2007-04-06, or alternatively:

	http://common-lisp.net/pipermail/slime-devel/2007-April/006087.html

	* swank.lisp (make-compound-prefix-matcher): New function.
	Abstracted from COMPOUND-PREFIX-MATCH.
	(compound-prefix-match): Use MAKE-COMPOUND-PREFIX-MATCHER.
	(compound-prefix-match/ci/underscores): Removed.

	(completions): Slight docstring modification, also added an
	examplary use case; use LONGEST-COMMON-PREFIX instead of
	LONGEST-COMPLETION.
	(completions-for-character): Use LONGEST-COMMON-PREFIX, and
	MAKE-COMPOUND-PREFIX-MATCHER.
	
	(longest-completion): Removed. Not needed anymore.
	(tokenize-completion): Likewise.
	(untokenize-completion): Likewise.
	(transpose-lists): Likewise.
	(longest-completion/underscores): Likewise.
	(tokenize-completion/underscores): Likewise.
	(untokenize-completion/underscores): Likewise.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: slime-longest-completion-fix.diff
Type: text/x-diff
Size: 8522 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/slime-devel/attachments/20070428/3296198c/attachment.diff>