[slime-devel] slime-toggle-trace-fdefinition (C-c C-t)

[Antonio Menezes Leitao]

Luke Gorrie <luke at synap.se> writes:

> "Steven E. Harris" <seh at panix.com> writes:
>
>> Using SLIME updated to the current CVS in XEmacs 21.4.13 with CLISP
>> 2.33.1 on Cygwin, trying to trace a function (C-c C-t) causes XEmacs
>> to hang.
>
> Not to me but the trace stuff has been changed recently and may
> require some debugging :-)
>

And here is some more stuff to debug :-)

I find that the trace behaviour is inconsistent with other slime
functionalities regarding its use on empty space.

The slime-edit-definition command, for example, when triggered while
the cursor is over some empty space asks the user for the name to
edit.

The slime-toggle-trace-fdefinition, on the other hand, just says
"No symbol to trace".

I also find this behaviour a bit annoying because, even when I know
the name of the function to trace, it forces me to move around in the
buffers searching for the correct function definition or function call
just to point at it and trace it.

I have a small change to propose that removes the inconsistency:

Index: slime.el
===================================================================
RCS file: /project/slime/cvsroot/slime/slime.el,v
retrieving revision 1.466
diff -r1.466 slime.el
5397,5401c5397,5398
<     (cond ((not spec)
<            (error "No symbol to trace"))
< 	  (t
<            (let ((spec (slime-trace-query spec)))
<              (message "%s" (slime-eval `(swank:swank-toggle-trace ,spec))))))))
---
>     (let ((spec (slime-trace-query spec)))
>       (message "%s" (slime-eval `(swank:swank-toggle-trace ,spec))))))
5406c5403,5405
<   (cond ((symbolp spec)
---
>   (cond ((null spec)
>          (slime-read-from-minibuffer "(Un)trace: "))
>         ((symbolp spec)


Could any of the slime gurus comment on this?

Best regards,

António Leitão.