[slime-cvs] CVS update: slime/ChangeLog slime/slime.el

[Brian Downing]

Update of /project/slime/cvsroot/slime
In directory common-lisp.net:/tmp/cvs-serv16890

Modified Files:
	ChangeLog slime.el 
Log Message:
* slime.el (slime-repl-send-input): Fixed a subtle difference in
sending input to the Lisp introduced in 1.316.  The newline was
not getting sent, resulting in the Lisp constantly asking for more
read data.  I believe the code has been adjusted to behave the
same as 1.315 with regard to sending newlines.
Also adjusted the `slime-repl-old-input' text property to end just
before the newline, not just after.  This causes a gap between
inputs even if no Lisp output appeared in between, so that putting
point on an old line and hitting RET will only call up that line,
and hitting RET in the middle of the current line will send it and
not bring up a confusing combination of all previous input.
Many thanks to Loyd Fueston for pinpointing the date and exact
patch for when this problem was introduced.


Date: Wed Jun 23 21:32:17 2004
Author: bdowning

Index: slime/ChangeLog
diff -u slime/ChangeLog:1.425 slime/ChangeLog:1.426
--- slime/ChangeLog:1.425	Wed Jun 23 15:50:59 2004
+++ slime/ChangeLog	Wed Jun 23 21:32:17 2004
@@ -1,3 +1,19 @@
+2004-06-24  Brian Downing  <bdowning at lavos.net>
+
+ 	* slime.el (slime-repl-send-input): Fixed a subtle difference in
+	sending input to the Lisp introduced in 1.316.  The newline was
+	not getting sent, resulting in the Lisp constantly asking for more
+	read data.  I believe the code has been adjusted to behave the
+	same as 1.315 with regard to sending newlines.
+	Also adjusted the `slime-repl-old-input' text property to end just
+	before the newline, not just after.  This causes a gap between
+	inputs even if no Lisp output appeared in between, so that putting
+	point on an old line and hitting RET will only call up that line,
+	and hitting RET in the middle of the current line will send it and
+	not bring up a confusing combination of all previous input.
+	Many thanks to Loyd Fueston for pinpointing the date and exact
+	patch for when this problem was introduced.
+
 2004-06-23  Brian Downing  <bdowning at lavos.net>
 
 	* slime.el: Re-added most of Luke's patches from yesterday.  It


Index: slime/slime.el
diff -u slime/slime.el:1.334 slime/slime.el:1.335
--- slime/slime.el:1.334	Wed Jun 23 15:50:59 2004
+++ slime/slime.el	Wed Jun 23 21:32:17 2004
@@ -2300,13 +2300,14 @@
 If NEWLINE is true then add a newline at the end of the input."
   (when (< (point) slime-repl-input-start-mark)
     (error "No input at point."))
+  (goto-char slime-repl-input-end-mark)
+  (add-text-properties slime-repl-input-start-mark (point)
+                       '(face slime-repl-input-face
+                              rear-nonsticky (face)
+                              slime-repl-old-input t))
+  (when newline (insert "\n"))
   (let ((input (slime-repl-current-input)))
     (goto-char slime-repl-input-end-mark)
-    (when newline (insert "\n"))
-    (add-text-properties slime-repl-input-start-mark (point)
-                         '(face slime-repl-input-face
-                                rear-nonsticky (face)
-                                slime-repl-old-input t))
     (slime-mark-input-start)
     (slime-mark-output-start)
     (slime-repl-send-string input)))