[rucksack-devel] Two patches

[Nikodemus Siivola]

"Arthur Lemmens" <alemmens at xs4all.nl> writes:

> Nikodemus wrote:

>> which means cache-touch-object on clean in-memory objects can
>> work before the object has been deserialized.
>
> ...but I don't really understand what you're saying here.  Do
> you mean 'serialized' or do you really mean 'deserialized'?  Why
> would you want to touch a clean in-memory object?  If it's
> clean, you shouldn't touch it, right?

That was in response to retaining the object outside a transaction: in
the second transaction it was clean, but not in cache -- so you tried
to touch it, it wasn't in the cache, which broke things.

By passing objects instead of object-ids to the cache-touch object it
was no longer necessary to get the object from the cache in order to
mark it dirty in the transaction, so the internal-error which I hit
due to the out-of-transaction reference could be avoided.

So my motivation wasn't quite correct there -- but I think the patch
should still be correct. If you wish the same consistency checking as
prior, the internal-error needs to be kept.

Cheers,

  -- Nikodemus              Schemer: "Buddha is small, clean, and serious."
                   Lispnik: "Buddha is big, has hairy armpits, and laughs."