From edi at agharta.de  Tue Jun  7 06:22:18 2005
From: edi at agharta.de (Edi Weitz)
Date: Tue, 07 Jun 2005 08:22:18 +0200
Subject: [mod-lisp-devel] Last-Modified header
Message-ID: <uekbelm91.fsf@agharta.de>

Hi!

I'm including small patches to both mod_lisp and mod_lisp2 that will
set the r->mtime slot directly instead of going through
ap_update_mtime.  The reason is that ap_update_mtime will only change
the mtime slot if the parameter it gets is greater than what's already
in r->mtime.  This makes sense for situations where the page sent to
the browser is based on a file and Apache has an idea of the last
modification date of this file but obviously this doesn't apply to
mod_lisp.  I've run into situations where Apache refused to set the
Last-Modified header I sent from Lisp and this patch fixes it.

(Look at the source code of ap_update_mtime to see that this really
isn't a big deal.)

Cheers,
Edi.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mod_lisp.diff
Type: text/x-patch
Size: 656 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/mod-lisp-devel/attachments/20050607/9b13b5a1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mod_lisp2.diff
Type: text/x-patch
Size: 882 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/mod-lisp-devel/attachments/20050607/9b13b5a1/attachment-0001.bin>

From marc.battyani at fractalconcept.com  Tue Jun  7 09:55:01 2005
From: marc.battyani at fractalconcept.com (Marc Battyani)
Date: Tue, 7 Jun 2005 11:55:01 +0200
Subject: [mod-lisp-devel] Last-Modified header
References: <uekbelm91.fsf@agharta.de>
Message-ID: <01c701c56b46$f96e5f10$0a02a8c0@marcxp>

"Edi Weitz" <edi at agharta.de> wrote:
>
> I'm including small patches to both mod_lisp and mod_lisp2 that will
> set the r->mtime slot directly instead of going through
> ap_update_mtime.  The reason is that ap_update_mtime will only change
> the mtime slot if the parameter it gets is greater than what's already
> in r->mtime.  This makes sense for situations where the page sent to
> the browser is based on a file and Apache has an idea of the last
> modification date of this file but obviously this doesn't apply to
> mod_lisp.  I've run into situations where Apache refused to set the
> Last-Modified header I sent from Lisp and this patch fixes it.
>
> (Look at the source code of ap_update_mtime to see that this really
> isn't a big deal.)

Thanks. I've committed this to the repository. I also added a small fix form
Alain Picard.

Cheers,

Marc