From attila.lendvai at gmail.com Tue Nov 17 14:16:15 2009 From: attila.lendvai at gmail.com (Attila Lendvai) Date: Tue, 17 Nov 2009 15:16:15 +0100 Subject: [Metabang-bind-devel] bug due to bind-fix-nils with test case Message-ID: Gary, take a look at this: (bind (((&optional (default-value nil default-value-supplied?)) (foo)))) (DESTRUCTURING-BIND (&OPTIONAL (DEFAULT-VALUE #:BIND-IGNORE-1307 DEFAULT-VALUE-SUPPLIED?)) (FOO) (DECLARE (IGNORE #:BIND-IGNORE-1307))) bind-fix-nils goes a little astray... how about using (string= name "_") instead of NIL as a marker for ignored bindings? it would be much less fragile, and would also be better for the human pattern matcher when staring at the code (imho). it would break backward compatibility, but record that in the patch description and users can chose not to pull it or delay pulling it... and the breakage would be an easily fixable direct error anyway, not some hidden bug. -- attila