[mcclim-devel] Re: [mcclim-cvs] CVS update: mcclim/presentation-defs.lisp

[Andy Hefner]

Having read the spec, I see I'm wrong about this. Sorry about that.


On Wed, 19 Jan 2005 19:05:51 -0500, Andy Hefner <ahefner at gmail.com> wrote:
> I think this is wrong. McCLIM now returns the class name of the object
> even when no corresponding presentation type has been defined. On Jan
> 2nd I commited a change to stop this from happening (I think it was
> causing problems with the listener), which this seems to undo.
> 
> Thoughts?
> 
> 
> On Wed, 19 Jan 2005 14:44:46 -0800 (PST), Timothy Moore
> <tmoore at common-lisp.net> wrote:
> > Update of /project/mcclim/cvsroot/mcclim
> > In directory common-lisp.net:/tmp/cvs-serv20050
> >
> > Modified Files:
> >         presentation-defs.lisp
> > Log Message:
> > For CLOS objects, make presentation-type-of return the name of the class if possible
> > Date: Wed Jan 19 14:44:46 2005
> > Author: tmoore
> >
> > Index: mcclim/presentation-defs.lisp
> > diff -u mcclim/presentation-defs.lisp:1.39 mcclim/presentation-defs.lisp:1.40
> > --- mcclim/presentation-defs.lisp:1.39  Tue Jan 11 05:02:19 2005
> > +++ mcclim/presentation-defs.lisp       Wed Jan 19 14:44:46 2005
> > @@ -87,11 +87,15 @@
> >  (defmethod presentation-type-of ((object standard-object))
> >    (multiple-value-bind (name lambda-list)
> >        (get-ptype-from-class-of object)
> > -    (if (and name
> > -             (or (null lambda-list)
> > -                 (member (first lambda-list) lambda-list-keywords)))
> > -        name
> > -        (call-next-method))))
> > +    (cond ((and name
> > +               (or (null lambda-list)
> > +                   (member (first lambda-list) lambda-list-keywords)))
> > +          name)
> > +         (name
> > +          'standard-object)
> > +         (t (let* ((class (class-of object))
> > +                   (class-name (class-name class)))
> > +              (or class-name class))))))
> >
> >  (defmethod presentation-type-of ((object structure-object))
> >    (multiple-value-bind (name lambda-list)
> > @@ -100,7 +104,6 @@
> >              (member lambda-list lambda-list-keywords))
> >          name
> >          (call-next-method))))
> > -
> >
> >  (define-presentation-generic-function
> >      %map-over-presentation-type-supertypes
> >
> > _______________________________________________
> > mcclim-cvs mailing list
> > mcclim-cvs at common-lisp.net
> > http://common-lisp.net/cgi-bin/mailman/listinfo/mcclim-cvs
> >
>